Fisheye on ro-firmware/firmware

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Mon, 30 Jun 2025 17:32:44 -0700

Michael Garthwaite committed 051cd04 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-7, +8)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-53, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/TemperatureSensor.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterPreGen.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.h	(-10, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: formatting

Michael Garthwaite — Mon, 30 Jun 2025 14:07:30 -0700

Michael Garthwaite committed b3768ad on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: formatting

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Mon, 30 Jun 2025 14:06:37 -0700

Michael Garthwaite committed f3c7025 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Drivers/TemperatureSensor.c

(-0, +1)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Mon, 30 Jun 2025 13:59:38 -0700

Michael Garthwaite committed d5574e1 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Drivers/FluidPump.c	(-13, +23)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-16, +16)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.h	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/TemperatureSensor.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FilterFlush.c	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterGen.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterPreGen.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-11, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

Michael Garthwaite — Mon, 30 Jun 2025 13:24:36 -0700

Michael Garthwaite committed 863f8f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

· /firmware/App/Controllers/BoostPump.c	(-27, +27)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BoostPump.h	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-28, +28)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensor.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FlowSensor.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FlowSensor.h	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Flow.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: implemented RO and boost control states between target pressure and target flow

Michael Garthwaite — Wed, 25 Jun 2025 14:50:03 -0700

Michael Garthwaite committed 2506bb8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: implemented RO and boost control states between target pressure and target flow

· /firmware/App/Controllers/BoostPump.c	(-6, +31)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +28)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. addressed formatting

Michael Garthwaite — Wed, 25 Jun 2025 11:25:47 -0700

Michael Garthwaite committed 5e5ece6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments. addressed formatting

· /firmware/App/Controllers/BoostPump.c	(-31, +31)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-29, +29)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 25 Jun 2025 11:11:50 -0700

Michael Garthwaite committed 9469502 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/Heaters.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 25 Jun 2025 11:10:49 -0700

Michael Garthwaite committed a80e7b6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/ROPump.c

(-8, +6)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Wed, 25 Jun 2025 11:07:37 -0700

Michael Garthwaite committed 677d24e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/ROPump.h

(-3, +3)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 25 Jun 2025 11:03:35 -0700

Michael Garthwaite committed 815f879 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/Heaters.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Wed, 25 Jun 2025 11:01:08 -0700

Michael Garthwaite committed 3f5c0e2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c	(-5, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-11, +8)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Wed, 25 Jun 2025 10:56:28 -0700

Michael Garthwaite committed e6c6e39 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c	(-29, +32)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-28, +30)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: reflect changes from boost pump to ro pump

Michael Garthwaite — Wed, 25 Jun 2025 10:36:30 -0700

Michael Garthwaite committed c71fc50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: reflect changes from boost pump to ro pump

· /firmware/App/Controllers/ROPump.c

(-11, +9)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Wed, 25 Jun 2025 10:26:08 -0700

Michael Garthwaite committed 319d8e8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c	(-19, +16)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BoostPump.h	(-3, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: renamed water generation defs

Michael Garthwaite — Wed, 25 Jun 2025 09:08:58 -0700

Michael Garthwaite committed 97bcc8f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: renamed water generation defs

· /firmware/App/Modes/ModeWaterGen.c

(-10, +10)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented missing overrides for op mode.

Michael Garthwaite — Tue, 24 Jun 2025 15:23:23 -0700

Michael Garthwaite committed d36643b on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: Implemented missing overrides for op mode.

· /firmware/App/Modes/OperationModes.c	(-0, +56)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Tue, 24 Jun 2025 10:37:55 -0700

Michael Garthwaite committed 4f6fd06 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c

(-2, +0)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed error

Michael Garthwaite — Mon, 23 Jun 2025 13:12:06 -0700

Michael Garthwaite committed 4ab396a on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: fixed error

· /firmware/App/Modes/FilterFlush.c

(-15, +15)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review fix.

Michael Garthwaite — Mon, 23 Jun 2025 10:13:49 -0700

Michael Garthwaite committed 867bbcd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review fix.

· /firmware/App/Drivers/PressureSensor.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: added header for fluid pump monitors. doxygen fixes.

Michael Garthwaite — Mon, 23 Jun 2025 10:12:07 -0700

Michael Garthwaite committed cd1aa72 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: added header for fluid pump monitors. doxygen fixes.

· /firmware/App/Controllers/BoostPump.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FilterFlush.c	(-0, +141)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FilterFlush.h	(-7, +43)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterGen.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterGen.h	(-2, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: various naming changes across various files. Switching RO to FP.

Michael Garthwaite — Wed, 18 Jun 2025 15:21:44 -0700

Michael Garthwaite committed 99498a5 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: various naming changes across various files. Switching RO to FP.

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-9, +9)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-0, +793)

| History

| Source

· /firmware/App/Drivers/ConductivitySensor.h

(-0, +77)

| History

| Source

· /firmware/App/Drivers/ConductivitySensors.c

(-792, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensors.h

(-77, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PAL.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-15, +4)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.h

(-1, +1)

| History

| Source

| Diff

… 43 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Fluid Pump controllers. Renamed RO common to FP common to be in line of subsystem naming.

Michael Garthwaite — Wed, 18 Jun 2025 15:20:51 -0700

Michael Garthwaite committed 17a4487 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: Fluid Pump controllers. Renamed RO common to FP common to be in line of subsystem naming.

· /firmware/App/Controllers/BoostPump.c	(-0, +648)	\| History	\| Source
· /firmware/App/Controllers/BoostPump.h	(-0, +75)	\| History	\| Source
· /firmware/App/Controllers/ROPump.c	(-110, +486)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-7, +23)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/BoostPump.c	(-304, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/BoostPump.h	(-61, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-0, +363)	\| History	\| Source
· /firmware/App/Drivers/FluidPump.h	(-0, +69)	\| History	\| Source
· /firmware/App/FPCommon.h	(-0, +62)	\| History	\| Source
· /firmware/App/ROCommon.h	(-92, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-8, +39)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated message table to be 2d

Michael Garthwaite — Mon, 16 Jun 2025 09:14:14 -0700

Michael Garthwaite committed 0126254 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: updated message table to be 2d

· /firmware/App/Services/FpgaRO.c	(-157, +95)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.h	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-72, +43)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Fixed release build missing all include options

Michael Garthwaite — Tue, 10 Jun 2025 15:48:02 -0700

Michael Garthwaite committed 5c54946 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: Fixed release build missing all include options

· /firmware/.cproject	(-0, +17)	\| History	\| Source	\| Diff
· /firmware/.settings/org.eclipse.core.resources.prefs	(-0, +21)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed implicit declarations for x pressure sensors. added x5 to broadcasts

Michael Garthwaite — Tue, 13 May 2025 13:40:41 -0700

Michael Garthwaite committed 85a88a4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: fixed implicit declarations for x pressure sensors. added x5 to broadcasts

· /firmware/App/Monitors/Pressure.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.h	(-0, +20)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: X pressure senors implemented to publishing and sensor reading

Michael Garthwaite — Tue, 29 Apr 2025 14:59:33 -0700

Michael Garthwaite committed 69e32c5 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: X pressure senors implemented to publishing and sensor reading

· /firmware/App/Drivers/PressureSensor.c	(-0, +17)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-1, +7)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.h	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaRO.c	(-0, +192)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: added uninitialized variables to init function of mode water gen

Michael Garthwaite — Tue, 29 Apr 2025 14:23:05 -0700

Michael Garthwaite committed 27852fd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: added uninitialized variables to init function of mode water gen

· /firmware/App/Modes/ModeWaterGen.c

(-1, +3)

| History

| Source

| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): Bamboo Commit: Updated ROCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 25 Apr 2025 10:06:02 -0700

Dara Navaei committed 73a5cea on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 10 more in ro-firmware

Bamboo Commit: Updated ROCommon.h with build versions from Bamboo.

· /firmware/App/ROCommon.h

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): Bamboo Commit: Updated ROCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 24 Apr 2025 15:34:40 -0700

Dara Navaei committed dd901f6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 10 more in ro-firmware

Bamboo Commit: Updated ROCommon.h with build versions from Bamboo.

· /firmware/App/ROCommon.h

(-4, +4)

| History

| Source

| Diff