Fisheye on ro-firmware/firmware/App/Controllers/PermeateTank.c https://devapps.diality.us/changelog/~br%3DLDT-828-stop-state-fp/ro-firmware/firmware/App/Controllers/PermeateTank.c Recent activity in "ro-firmware" under directory /firmware/App/Controllers/PermeateTank.c ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Mon, 04 Aug 2025 09:26:42 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=9cbb00a9eba347697bdf5cee63962061ffa36c92 https://devapps.diality.us/changelog/ro-firmware?cs=9cbb00a9eba347697bdf5cee63962061ffa36c92 Michael Garthwaite committed 9cbb00a on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/PermeateTank.c (-2, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Fri, 01 Aug 2025 15:56:30 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c (-8, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-4, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.h (-1, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-6, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommFP.c (-1, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes Thu, 31 Jul 2025 11:49:31 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 Michael Garthwaite committed b92c26d on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

· /firmware/App/Controllers/BoostPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-7, +7) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-4, +5) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and c... Wed, 30 Jul 2025 11:24:46 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 Michael Garthwaite committed 6dd382e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

· /firmware/App/Controllers/PermeateTank.c (-5, +350) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-7, +10) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-9, +7) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-5, +6) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-6, +5) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-7, +8) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-123, +11) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-24, +25) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-12, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-1, +66) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-0, +20) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-76, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.h (-19, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-18, +26) | History | Source | Diff
… 6 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented FP fault mode. Removed math includes from flush modes. Tue, 29 Jul 2025 13:05:57 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=f79d3737907fd08293d56f60f9f439ac68c81855 https://devapps.diality.us/changelog/ro-firmware?cs=f79d3737907fd08293d56f60f9f439ac68c81855 Michael Garthwaite committed f79d373 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-19, +245) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: FP Safety shutdown override. fixed includes. Tue, 29 Jul 2025 12:15:18 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 Michael Garthwaite committed 8e72441 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: FP Safety shutdown override. fixed includes.

· /firmware/App/Controllers/PermeateTank.c (-0, +52) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-0, +65) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-39, +22) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.h (-3, +6) | History | Source | Diff
· /firmware/App/Modes/FPModeInitPOST.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPOperationModes.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +3) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): Revert "LDT-566: permeate tank file creation"... Fri, 25 Jul 2025 09:18:07 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=72ae2be3400d1671b3a9c0c6610938cd57055d8b https://devapps.diality.us/changelog/ro-firmware?cs=72ae2be3400d1671b3a9c0c6610938cd57055d8b Michael Garthwaite committed 72ae2be on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware Revert "LDT-566: permeate tank file creation"

This reverts commit 6e65344e6675394118806ce98dc428c27920e1cb.

· /firmware/App/Controllers/PermeateTank.c (-428, +0) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-60, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: permeate tank file creation Fri, 25 Jul 2025 09:16:59 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6e65344e6675394118806ce98dc428c27920e1cb https://devapps.diality.us/changelog/ro-firmware?cs=6e65344e6675394118806ce98dc428c27920e1cb Michael Garthwaite committed 6e65344 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: permeate tank file creation

· /firmware/App/Controllers/PermeateTank.c (-0, +428) | History | Source
· /firmware/App/Controllers/PermeateTank.h (-0, +60) | History | Source
]]>