Fisheye on ro-firmware/firmware/App/Drivers/ConductivitySensor.c

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Fri, 01 Aug 2025 12:22:15 -0700

Michael Garthwaite committed 9b91228 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.h	(-7, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-4, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check ...

Michael Garthwaite — Fri, 01 Aug 2025 12:08:14 -0700

Michael Garthwaite committed 3a5cc58 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

· /firmware/App/Controllers/BoostPump.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PressureCheck.c	(-0, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PressureCheck.h	(-15, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-5, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 09:58:35 -0700

Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-12, +11)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-0, +88)

| History

| Source

· /firmware/App/Modes/FPModeFault.h

(-0, +40)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.c

(-0, +66)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.h

(-0, +44)

| History

| Source

· /firmware/App/Modes/FPModeStandby.c

(-0, +149)

| History

| Source

· /firmware/App/Modes/FPModeStandby.h

(-0, +47)

| History

| Source

· /firmware/App/Modes/FPOperationModes.c

(-0, +475)

| History

| Source

· /firmware/App/Modes/FPOperationModes.h

(-0, +62)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.c

(-1, +2)

| History

| Source

| Diff

… 25 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple...

Michael Garthwaite — Wed, 02 Jul 2025 12:04:36 -0700

Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c

(-30, +34)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.c

(-139, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.h

(-51, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +0)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.h

(-0, +15)

| History

| Source

· /firmware/App/Modes/FlushFilter.c

(-0, +365)

| History

| Source

… 56 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

Michael Garthwaite — Mon, 30 Jun 2025 13:24:36 -0700

Michael Garthwaite committed 863f8f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

· /firmware/App/Controllers/BoostPump.c	(-27, +27)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BoostPump.h	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-28, +28)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensor.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FlowSensor.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FlowSensor.h	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Flow.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: various naming changes across various files. Switching RO to FP.

Michael Garthwaite — Wed, 18 Jun 2025 15:21:44 -0700

Michael Garthwaite committed 99498a5 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware

LDT-566: various naming changes across various files. Switching RO to FP.

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-9, +9)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-0, +793)

| History

| Source

· /firmware/App/Drivers/ConductivitySensor.h

(-0, +77)

| History

| Source

· /firmware/App/Drivers/ConductivitySensors.c

(-792, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensors.h

(-77, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PAL.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-15, +4)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.h

(-1, +1)

| History

| Source

| Diff

… 43 more files in changeset.