Fisheye on ro-firmware/firmware/App/Modes/FPModeStandby.c

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Fri, 01 Aug 2025 15:56:30 -0700

Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommFP.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 30 Jul 2025 13:30:55 -0700

Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c

(-11, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-650, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-60, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-18, +20)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-3, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-399, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-59, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-19, +24)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-2, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-10, +11)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-9, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-30, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-9, +4)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.c

(-1, +0)

| History

| Source

| Diff

… 5 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 09:58:35 -0700

Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-12, +11)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-0, +88)

| History

| Source

· /firmware/App/Modes/FPModeFault.h

(-0, +40)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.c

(-0, +66)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.h

(-0, +44)

| History

| Source

· /firmware/App/Modes/FPModeStandby.c

(-0, +149)

| History

| Source

· /firmware/App/Modes/FPModeStandby.h

(-0, +47)

| History

| Source

· /firmware/App/Modes/FPOperationModes.c

(-0, +475)

| History

| Source

· /firmware/App/Modes/FPOperationModes.h

(-0, +62)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.c

(-1, +2)

| History

| Source

| Diff

… 25 more files in changeset.