Fisheye on ro-firmware/firmware/App/Modes/ModeGenPermeate.h

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 30 Jul 2025 13:30:55 -0700

Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c

(-11, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-650, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-60, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-18, +20)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-3, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-399, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-59, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-19, +24)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-2, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-10, +11)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-9, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-30, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-9, +4)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.c

(-1, +0)

| History

| Source

| Diff

… 5 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: generate water modes both defeatured and ro featured

Michael Garthwaite — Wed, 09 Jul 2025 14:14:26 -0700

Michael Garthwaite committed 8d27258 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: generate water modes both defeatured and ro featured

· /firmware/App/Controllers/BoostPump.c

(-4, +31)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +28)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +15)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-39, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +395)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-7, +48)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-5, +17)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-21, +121)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-5, +299)

| History

| Source

| Diff

… 14 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple...

Michael Garthwaite — Wed, 02 Jul 2025 12:04:36 -0700

Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c

(-30, +34)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.c

(-139, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.h

(-51, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +0)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.h

(-0, +15)

| History

| Source

· /firmware/App/Modes/FlushFilter.c

(-0, +365)

| History

| Source

… 56 more files in changeset.

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LDT-332: init file commit. reworked Generate Permeate to Generate water. Naming has been changed.

Michael Garthwaite — Thu, 17 Apr 2025 13:20:55 -0700

Michael Garthwaite committed d19f700 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 11 more in ro-firmware

LDT-332: init file commit. reworked Generate Permeate to Generate water. Naming has been changed.

· /firmware/App/Modes/ModeGenPermeate.c	(-326, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.h	(-53, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeWaterGen.c	(-0, +326)	\| History	\| Source
· /firmware/App/Modes/ModeWaterGen.h	(-0, +53)	\| History	\| Source
· /firmware/App/Modes/ModeWaterPreGen.c	(-0, +16)	\| History	\| Source
· /firmware/App/Modes/ModeWaterPreGen.h	(-0, +16)	\| History	\| Source
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtRO.c	(-0, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAHI-273: code review comments.

Michael Garthwaite — Thu, 13 Mar 2025 14:33:23 -0700

Michael Garthwaite committed 4810468 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 12 more in ro-firmware

LEAHI-273: code review comments.

· /firmware/App/Modes/ModeGenPermeate.c	(-4, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAHI-273: additional code formatting and fixes from CR.

Michael Garthwaite — Wed, 05 Mar 2025 08:32:09 -0800

Michael Garthwaite committed 81ecdea on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 12 more in ro-firmware

LEAHI-273: additional code formatting and fixes from CR.

· /firmware/App/Modes/ModeGenPermeate.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAHI-273: various fixes found in code review.

Michael Garthwaite — Wed, 05 Mar 2025 08:21:41 -0800

Michael Garthwaite committed f8bdb3f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 12 more in ro-firmware

LEAHI-273: various fixes found in code review.

· /firmware/App/Modes/ModeGenPermeate.c	(-9, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.h	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.h	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): Init commit for generate water...

Michael Garthwaite — Tue, 04 Mar 2025 13:21:06 -0800

Michael Garthwaite committed 9ad496e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 12 more in ro-firmware

Init commit for generate water

created DD interface, and mode gen permeate. Tank Switching logic is in progress.

· /firmware/App/Modes/ModeGenPermeate.c	(-0, +265)	\| History	\| Source
· /firmware/App/Modes/ModeGenPermeate.h	(-0, +56)	\| History	\| Source
· /firmware/App/Modes/ModeStandby.c	(-5, +153)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +21)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-0, +177)	\| History	\| Source
· /firmware/App/Services/DDInterface.h	(-0, +52)	\| History	\| Source
· /firmware/App/Services/Messaging.c	(-14, +17)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.h	(-0, +2)	\| History	\| Source	\| Diff