Fisheye on ro-firmware/firmware/App/Modes/ModePreGenPermeateDefeatured.c

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Fri, 01 Aug 2025 12:22:15 -0700

Michael Garthwaite committed 9b91228 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.h	(-7, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-4, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and c...

Michael Garthwaite — Wed, 30 Jul 2025 11:24:46 -0700

Michael Garthwaite committed 6dd382e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

· /firmware/App/Controllers/PermeateTank.c

(-5, +350)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.h

(-7, +10)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-9, +7)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-5, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-6, +5)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-7, +8)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-123, +11)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeate.c

(-24, +25)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeateDefeatured.c

(-12, +12)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.c

(-1, +66)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.h

(-0, +20)

| History

| Source

| Diff

· /firmware/App/Monitors/WaterQualityMonitor.c

(-76, +0)

| History

| Source

| Diff

· /firmware/App/Monitors/WaterQualityMonitor.h

(-19, +0)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmtFP.c

(-18, +26)

| History

| Source

| Diff

… 6 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 10:06:32 -0700

Michael Garthwaite committed dfec1cd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: develop fixes

· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-3, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 09:58:35 -0700

Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-12, +11)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-0, +88)

| History

| Source

· /firmware/App/Modes/FPModeFault.h

(-0, +40)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.c

(-0, +66)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.h

(-0, +44)

| History

| Source

· /firmware/App/Modes/FPModeStandby.c

(-0, +149)

| History

| Source

· /firmware/App/Modes/FPModeStandby.h

(-0, +47)

| History

| Source

· /firmware/App/Modes/FPOperationModes.c

(-0, +475)

| History

| Source

· /firmware/App/Modes/FPOperationModes.h

(-0, +62)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.c

(-1, +2)

| History

| Source

| Diff

… 25 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with la...

Michael Garthwaite — Fri, 25 Jul 2025 08:28:53 -0700

Michael Garthwaite committed 337136f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

· /firmware/App/Controllers/Valves.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +4)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-0, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeate.c

(-0, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeateDefeatured.c

(-0, +9)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-0, +3)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.c

(-25, +125)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Monitors/Pressure.c

(-167, +2)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.c

(-308, +2)

| History

| Source

| Diff

… 6 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed...

Michael Garthwaite — Tue, 15 Jul 2025 15:54:42 -0700

Michael Garthwaite committed 1cf11f4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

· /firmware/App/Controllers/BoostPump.c	(-45, +84)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BoostPump.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-59, +88)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +11)	\| History	\| Source	\| Diff
· /firmware/App/FPCommon.h	(-15, +25)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +21)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-12, +23)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +21)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-21, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-5, +50)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: generate water modes both defeatured and ro featured

Michael Garthwaite — Wed, 09 Jul 2025 14:14:26 -0700

Michael Garthwaite committed 8d27258 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: generate water modes both defeatured and ro featured

· /firmware/App/Controllers/BoostPump.c

(-4, +31)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +28)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +15)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-39, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +395)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-7, +48)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-5, +17)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-21, +121)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-5, +299)

| History

| Source

| Diff

… 14 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple...

Michael Garthwaite — Wed, 02 Jul 2025 12:04:36 -0700

Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c

(-30, +34)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.c

(-139, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.h

(-51, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +0)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.h

(-0, +15)

| History

| Source

· /firmware/App/Modes/FlushFilter.c

(-0, +365)

| History

| Source

… 56 more files in changeset.