Fisheye on ro-firmware/firmware/App/Modes/ModePreGenPermeateDefeatured.h

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Fri, 01 Aug 2025 15:56:30 -0700

Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommFP.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Fri, 01 Aug 2025 12:22:15 -0700

Michael Garthwaite committed 9b91228 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.h	(-7, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-4, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: generate water modes both defeatured and ro featured

Michael Garthwaite — Wed, 09 Jul 2025 14:14:26 -0700

Michael Garthwaite committed 8d27258 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: generate water modes both defeatured and ro featured

· /firmware/App/Controllers/BoostPump.c

(-4, +31)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +28)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-1, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +15)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-39, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +395)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-7, +48)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-5, +17)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-21, +121)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-5, +299)

| History

| Source

| Diff

… 14 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple...

Michael Garthwaite — Wed, 02 Jul 2025 12:04:36 -0700

Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c

(-30, +34)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.c

(-139, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FilterFlush.h

(-51, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +0)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.h

(-0, +15)

| History

| Source

· /firmware/App/Modes/FlushFilter.c

(-0, +365)

| History

| Source

… 56 more files in changeset.