Fisheye on ro-firmware/firmware/App https://devapps.diality.us/changelog/~br%3DLDT-828-stop-state-fp/ro-firmware/firmware/App Recent activity in "ro-firmware" under directory /firmware/App ro-firmware (LDT-828-stop-state-fp): LDT-828: fixed pressure sensor conversions for alpha units Wed, 20 Aug 2025 08:21:51 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=bbdf8f6ba5a8968b0a9ce3f2ea0a77a0a8c0d9f7 https://devapps.diality.us/changelog/ro-firmware?cs=bbdf8f6ba5a8968b0a9ce3f2ea0a77a0a8c0d9f7 Michael Garthwaite committed bbdf8f6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 6 more in ro-firmware LDT-828: fixed pressure sensor conversions for alpha units

· /firmware/App/Drivers/PressureSensor.c (-7, +8) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Wed, 06 Aug 2025 08:24:10 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=c76b4f0f821e44144b1a169684b46c596bb9173a https://devapps.diality.us/changelog/ro-firmware?cs=c76b4f0f821e44144b1a169684b46c596bb9173a Dara Navaei committed c76b4f0 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 7 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Mon, 04 Aug 2025 09:26:42 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=9cbb00a9eba347697bdf5cee63962061ffa36c92 https://devapps.diality.us/changelog/ro-firmware?cs=9cbb00a9eba347697bdf5cee63962061ffa36c92 Michael Garthwaite committed 9cbb00a on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/PermeateTank.c (-2, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Fri, 01 Aug 2025 15:56:30 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c (-8, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-4, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.h (-1, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-6, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommFP.c (-1, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Fri, 01 Aug 2025 12:22:15 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=9b91228c0cb3eee3f06cfab4436e812722187839 https://devapps.diality.us/changelog/ro-firmware?cs=9b91228c0cb3eee3f06cfab4436e812722187839 Michael Garthwaite committed 9b91228 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.h (-7, +6) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-4, +8) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h (-6, +6) | History | Source | Diff
· /firmware/source/sys_main.c (-2, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check ... Fri, 01 Aug 2025 12:08:14 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 Michael Garthwaite committed 3a5cc58 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

· /firmware/App/Controllers/BoostPump.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-4, +6) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.c (-0, +0) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.h (-15, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-5, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed macro calls Thu, 31 Jul 2025 11:51:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=27566fb95c3865851e3b0b4bd4668474bfdbfcde https://devapps.diality.us/changelog/ro-firmware?cs=27566fb95c3865851e3b0b4bd4668474bfdbfcde Michael Garthwaite committed 27566fb on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed macro calls

· /firmware/App/Controllers/ROPump.c (-4, +4) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes Thu, 31 Jul 2025 11:49:31 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 Michael Garthwaite committed b92c26d on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

· /firmware/App/Controllers/BoostPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-7, +7) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-4, +5) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Wed, 30 Jul 2025 13:30:55 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c (-11, +5) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-650, +0) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-60, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-18, +20) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-399, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-59, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-19, +24) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-10, +11) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-9, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-30, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.h (-9, +4) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-1, +0) | History | Source | Diff
… 5 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and c... Wed, 30 Jul 2025 11:24:46 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 Michael Garthwaite committed 6dd382e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

· /firmware/App/Controllers/PermeateTank.c (-5, +350) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-7, +10) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-9, +7) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-5, +6) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-6, +5) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-7, +8) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-123, +11) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-24, +25) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-12, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-1, +66) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-0, +20) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-76, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.h (-19, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-18, +26) | History | Source | Diff
… 6 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed messaging ACK Tue, 29 Jul 2025 15:54:08 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=1301bfde565dbdae1a8c168090938d94f58cef13 https://devapps.diality.us/changelog/ro-firmware?cs=1301bfde565dbdae1a8c168090938d94f58cef13 Michael Garthwaite committed 1301bfd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed messaging ACK

· /firmware/App/Services/Messaging.c (-4, +4) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented FP fault mode. Removed math includes from flush modes. Tue, 29 Jul 2025 13:05:57 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=f79d3737907fd08293d56f60f9f439ac68c81855 https://devapps.diality.us/changelog/ro-firmware?cs=f79d3737907fd08293d56f60f9f439ac68c81855 Michael Garthwaite committed f79d373 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-19, +245) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: FP Safety shutdown override. fixed includes. Tue, 29 Jul 2025 12:15:18 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 Michael Garthwaite committed 8e72441 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: FP Safety shutdown override. fixed includes.

· /firmware/App/Controllers/PermeateTank.c (-0, +52) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-0, +65) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-39, +22) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.h (-3, +6) | History | Source | Diff
· /firmware/App/Modes/FPModeInitPOST.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPOperationModes.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +3) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop... Tue, 29 Jul 2025 10:06:32 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=dfec1cd93855e2b0aebfb2303f5fc8584a012440 https://devapps.diality.us/changelog/ro-firmware?cs=dfec1cd93855e2b0aebfb2303f5fc8584a012440 Michael Garthwaite committed dfec1cd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware WIP on develop

LDT-566: develop fixes

· /firmware/App/Modes/FlushConcentrate.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-5, +5) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-3, +3) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop... Tue, 29 Jul 2025 09:58:35 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-12, +11) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +88) | History | Source
· /firmware/App/Modes/FPModeFault.h (-0, +40) | History | Source
· /firmware/App/Modes/FPModeInitPOST.c (-0, +66) | History | Source
· /firmware/App/Modes/FPModeInitPOST.h (-0, +44) | History | Source
· /firmware/App/Modes/FPModeStandby.c (-0, +149) | History | Source
· /firmware/App/Modes/FPModeStandby.h (-0, +47) | History | Source
· /firmware/App/Modes/FPOperationModes.c (-0, +475) | History | Source
· /firmware/App/Modes/FPOperationModes.h (-0, +62) | History | Source
· /firmware/App/Modes/FlushConcentrate.c (-1, +2) | History | Source | Diff
… 25 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed valve order Fri, 25 Jul 2025 13:12:29 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=9e2a4a80080b685c1afc6283a0ed2b58dd5bd94a https://devapps.diality.us/changelog/ro-firmware?cs=9e2a4a80080b685c1afc6283a0ed2b58dd5bd94a Michael Garthwaite committed 9e2a4a8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed valve order

· /firmware/App/Controllers/Valves.h (-3, +3) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed valve ordering Fri, 25 Jul 2025 13:09:48 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=60292d27dd9bde4c09bda3ac375470f22b6b3401 https://devapps.diality.us/changelog/ro-firmware?cs=60292d27dd9bde4c09bda3ac375470f22b6b3401 Michael Garthwaite committed 60292d2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed valve ordering

· /firmware/App/Controllers/Valves.h (-2, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): Revert "LDT-566: permeate tank file creation"... Fri, 25 Jul 2025 09:18:07 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=72ae2be3400d1671b3a9c0c6610938cd57055d8b https://devapps.diality.us/changelog/ro-firmware?cs=72ae2be3400d1671b3a9c0c6610938cd57055d8b Michael Garthwaite committed 72ae2be on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware Revert "LDT-566: permeate tank file creation"

This reverts commit 6e65344e6675394118806ce98dc428c27920e1cb.

· /firmware/App/Controllers/PermeateTank.c (-428, +0) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-60, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: permeate tank file creation Fri, 25 Jul 2025 09:16:59 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6e65344e6675394118806ce98dc428c27920e1cb https://devapps.diality.us/changelog/ro-firmware?cs=6e65344e6675394118806ce98dc428c27920e1cb Michael Garthwaite committed 6e65344 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: permeate tank file creation

· /firmware/App/Controllers/PermeateTank.c (-0, +428) | History | Source
· /firmware/App/Controllers/PermeateTank.h (-0, +60) | History | Source
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with la... Fri, 25 Jul 2025 08:28:53 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=337136fc77fe5628fa727aac6252a06238561a10 https://devapps.diality.us/changelog/ro-firmware?cs=337136fc77fe5628fa727aac6252a06238561a10 Michael Garthwaite committed 337136f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

· /firmware/App/Controllers/Valves.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +4) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-0, +7) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-0, +3) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-0, +9) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +3) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-25, +125) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.h (-0, +1) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-167, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-308, +2) | History | Source | Diff
… 6 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop... Tue, 22 Jul 2025 14:51:23 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=30d20b2415fa9a6069044a54c3b1fe2c00cb894b https://devapps.diality.us/changelog/ro-firmware?cs=30d20b2415fa9a6069044a54c3b1fe2c00cb894b Michael Garthwaite committed 30d20b2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

· /firmware/App/Controllers/Valves.h (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixes for removing P22 and P23. fix warnings Tue, 22 Jul 2025 14:08:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=81aa682aa24931c7f44aea82ec72fb3dfabc7890 https://devapps.diality.us/changelog/ro-firmware?cs=81aa682aa24931c7f44aea82ec72fb3dfabc7890 Michael Garthwaite committed 81aa682 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixes for removing P22 and P23. fix warnings

· /firmware/App/Controllers/Heaters.c (-24, +24) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-35, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-30, +6) | History | Source | Diff
· /firmware/App/Services/FpgaFP.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-0, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-2, +4) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Changed temperature handling back to their respective drivers. Kept combined published temperature value. Tue, 22 Jul 2025 13:47:10 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=af3b8065167834683ec01c8c8342b3d196fca593 https://devapps.diality.us/changelog/ro-firmware?cs=af3b8065167834683ec01c8c8342b3d196fca593 Michael Garthwaite committed af3b806 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Changed temperature handling back to their respective drivers. Kept combined published temperature value.

· /firmware/App/Monitors/Pressure.c (-10, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-9, +9) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: merge pressure temperatures and conductivity temperature sensors into the temperature sensor broadcast Tue, 22 Jul 2025 12:40:13 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=41c4d109b7bc172d93ae1f4e4b20acaf96547807 https://devapps.diality.us/changelog/ro-firmware?cs=41c4d109b7bc172d93ae1f4e4b20acaf96547807 Michael Garthwaite committed 41c4d10 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: merge pressure temperatures and conductivity temperature sensors into the temperature sensor broadcast

· /firmware/App/Drivers/TemperatureSensor.h (-5, +3) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-9, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-5, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-3, +9) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-2, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Project renaming. Created version request handler. Updated mix max for fluid pumps Tue, 22 Jul 2025 12:09:59 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8940f67c485a23e20e14e4dc24e79339f80cc584 https://devapps.diality.us/changelog/ro-firmware?cs=8940f67c485a23e20e14e4dc24e79339f80cc584 Michael Garthwaite committed 8940f67 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Project renaming. Created version request handler. Updated mix max for fluid pumps

· /firmware/.project (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-1, +1) | History | Source | Diff
· /firmware/App/FPCommon.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-27, +33) | History | Source | Diff
· /firmware/App/Services/Messaging.h (-0, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure ... Thu, 17 Jul 2025 15:47:48 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 Michael Garthwaite committed 311c75c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

· /firmware/App/Controllers/BoostPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-17, +12) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-3, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate,... Tue, 15 Jul 2025 16:31:10 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=f4870116c87345ee0ea062df5b30187e1e113ddc https://devapps.diality.us/changelog/ro-firmware?cs=f4870116c87345ee0ea062df5b30187e1e113ddc Michael Garthwaite committed f487011 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

· /firmware/App/Controllers/BoostPump.c (-3, +22) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-0, +19) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-0, +5) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-4, +10) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed... Tue, 15 Jul 2025 15:54:42 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=1cf11f4c1f6a1f1fd40270889723fbec040fc7ec https://devapps.diality.us/changelog/ro-firmware?cs=1cf11f4c1f6a1f1fd40270889723fbec040fc7ec Michael Garthwaite committed 1cf11f4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

· /firmware/App/Controllers/BoostPump.c (-45, +84) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-59, +88) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-0, +11) | History | Source | Diff
· /firmware/App/FPCommon.h (-15, +25) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +21) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-12, +23) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +21) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-21, +8) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-5, +50) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed compiiler err Wed, 09 Jul 2025 14:23:45 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=29a015bc3ce9b9cdfcb033fb47d70af6a5ea3be9 https://devapps.diality.us/changelog/ro-firmware?cs=29a015bc3ce9b9cdfcb033fb47d70af6a5ea3be9 Michael Garthwaite committed 29a015b on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed compiiler err

· /firmware/App/Modes/FlushFilter.c (-2, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated flush exec functions to only call the transition function in one location. Wed, 09 Jul 2025 14:23:23 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=921198ed4c337cd5bcebbeedd7d724da4b1e23be https://devapps.diality.us/changelog/ro-firmware?cs=921198ed4c337cd5bcebbeedd7d724da4b1e23be Michael Garthwaite committed 921198e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: updated flush exec functions to only call the transition function in one location.

· /firmware/App/Modes/FlushConcentrate.c (-5, +7) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-6, +7) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-4, +6) | History | Source | Diff
]]>