Fisheye on leahi-dialin/leahi_dialin/ro/modules/valves.py

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): LEAHI-136: code review comments

Michael Garthwaite — Wed, 05 Feb 2025 13:31:10 -0800

Michael Garthwaite committed 08788e2 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

LEAHI-136: code review comments

· /leahi_dialin/ro/modules/conductivity_sensors.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/pressure_sensors.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/valves.py	(-1, +1)	\| History	\| Source	\| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): LEAHI-136: addressing code review comments. Updated pressure handler method.

Michael Garthwaite — Wed, 05 Feb 2025 10:37:51 -0800

Michael Garthwaite committed 7ae7087 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

LEAHI-136: addressing code review comments. Updated pressure handler method.

· /leahi_dialin/ro/modules/boost_pump.py	(-34, +32)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/conductivity_sensors.py	(-65, +21)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/flow_sensors.py	(-30, +28)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/levels.py	(-11, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/pressure_sensors.py	(-35, +73)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/valves.py	(-54, +53)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/reverse_osmosis.py	(-3, +3)	\| History	\| Source	\| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): fixed ro valve positioning

Michael Garthwaite — Tue, 10 Dec 2024 11:09:19 -0800

Michael Garthwaite committed 2d30541 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

fixed ro valve positioning

· /leahi_dialin/ro/modules/valves.py

(-5, +5)

| History

| Source

| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): updated RO valves with SPP valve.

Michael Garthwaite — Tue, 10 Dec 2024 10:25:28 -0800

Michael Garthwaite committed eed229f on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

updated RO valves with SPP valve.

· /leahi_dialin/ro/modules/valves.py

(-26, +30)

| History

| Source

| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): fixed boost pump import. fixed valve doc string

Michael Garthwaite — Tue, 03 Dec 2024 14:56:50 -0800

Michael Garthwaite committed 557a20a on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

fixed boost pump import. fixed valve doc string

· /leahi_dialin/ro/modules/boost_pump.py	(-1, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/valves.py	(-2, +2)	\| History	\| Source	\| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): WIP on develop...

Michael Garthwaite — Tue, 03 Dec 2024 12:12:29 -0800

Michael Garthwaite committed 4ef1f95 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

WIP on develop

fixed ro values override msg id

· /leahi_dialin/ro/modules/valves.py

(-1, +1)

| History

| Source

| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): updated pathing for imports

Michael Garthwaite — Tue, 03 Dec 2024 09:21:55 -0800

Michael Garthwaite committed 249bfa9 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

updated pathing for imports

· /leahi_dialin/ro/modules/boost_pump.py	(-6, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/levels.py	(-6, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/pressure_sensors.py	(-6, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/valves.py	(-1, +1)	\| History	\| Source	\| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): moved constants folder. Updated Ro valves

Michael Garthwaite — Tue, 03 Dec 2024 09:18:18 -0800

Michael Garthwaite committed 9941beb on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

moved constants folder. Updated Ro valves

· /leahi_dialin/ro/constants.py	(-18, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/boost_pump.py	(-1, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/constants.py	(-0, +18)	\| History	\| Source
· /leahi_dialin/ro/modules/valves.py	(-0, +291)	\| History	\| Source	\| Diff

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): Moving modules to folder...

Michael Garthwaite — Tue, 03 Dec 2024 09:06:07 -0800

Michael Garthwaite committed bba41bf on branch master, LDT-1195-dd-is-balancing-chamber-switching and 93 more in leahi-dialin

Moving modules to folder

updated naming and handlers

· /leahi-dialin/ro/modules/boost_pump.py	(-263, +0)	\| History	\| Source	\| Diff
· /leahi-dialin/ro/modules/levels.py	(-130, +0)	\| History	\| Source	\| Diff
· /leahi-dialin/ro/modules/pressure_sensors.py	(-173, +0)	\| History	\| Source	\| Diff
· /leahi-dialin/ro/modules/valves.py	(-0, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/boost_pump.py	(-0, +256)	\| History	\| Source
· /leahi_dialin/ro/modules/levels.py	(-0, +129)	\| History	\| Source
· /leahi_dialin/ro/modules/pressure_sensors.py	(-0, +171)	\| History	\| Source
· /leahi_dialin/ro/modules/valves.py	(-0, +0)	\| History	\| Source
· /leahi_dialin/ro/reverse_osmosis.py	(-0, +245)	\| History	\| Source	\| Diff