It has been decided we are not doing it for now.
will be asked to close.

this CR is to old and obsolete.

· /build/unittest.sh

(-3, +5)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 16:42:13 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=3b3f5c9ecc011f21754dcf053ae1ed81bb75e064 https://devapps.diality.us/changelog/scripts?cs=3b3f5c9ecc011f21754dcf053ae1ed81bb75e064 Dara Navaei committed 3b3f5c9 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added copying the common repository in the local directory

· /build/unittest.sh

(-1, +1)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 16:28:27 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=931b3bf105865cee9124e905c414e7ccb42b7f5f https://devapps.diality.us/changelog/scripts?cs=931b3bf105865cee9124e905c414e7ccb42b7f5f Dara Navaei committed 931b3bf on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added the project setup script

· /build/unittest.sh

(-20, +4)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 16:06:09 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=518ac0bd444954829f8434f644a3d86fdb2c28a4 https://devapps.diality.us/changelog/scripts?cs=518ac0bd444954829f8434f644a3d86fdb2c28a4 Dara Navaei committed 518ac0b on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added checks for the coverage and unit tests

· /build/unittest.sh

(-4, +16)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 13:56:40 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=132bce6618c8c631a2283443c7b6063e8cb3837d https://devapps.diality.us/changelog/scripts?cs=132bce6618c8c631a2283443c7b6063e8cb3837d Dara Navaei committed 132bce6 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added support scripts to the script

· /build/unittest.sh

(-7, +26)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 13:06:24 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=da10bcb5de6f91f9776bbc5076c3cf0c6c5c8aeb https://devapps.diality.us/changelog/scripts?cs=da10bcb5de6f91f9776bbc5076c3cf0c6c5c8aeb Dara Navaei committed da10bcb on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Removed the commented code

· /build/build.sh

(-10, +2)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 12:12:55 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=9373a31815722e47ec13b90dede0878532742954 https://devapps.diality.us/changelog/scripts?cs=9373a31815722e47ec13b90dede0878532742954 Dara Navaei committed 9373a31 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added export the build variables

· /build/build.sh

(-3, +3)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 11:54:59 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=a151e9867ca936d52f804f71a39fc42b194efbc9 https://devapps.diality.us/changelog/scripts?cs=a151e9867ca936d52f804f71a39fc42b194efbc9 Dara Navaei committed a151e98 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Updated the code

· /build/build.sh

(-0, +14)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 11:47:59 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=5ff855660f41e887f4c5aceada405bafff19f88e https://devapps.diality.us/changelog/scripts?cs=5ff855660f41e887f4c5aceada405bafff19f88e Dara Navaei committed 5ff8556 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added a function from support scripts to generate the code reivew script

· /build/build.sh

(-5, +6)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 11:37:45 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=43d8fbfc4a57b59de291efef3d0bdfaae1803005 https://devapps.diality.us/changelog/scripts?cs=43d8fbfc4a57b59de291efef3d0bdfaae1803005 Dara Navaei committed 43d8fbf on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added a function from support scripts to get the build number variables

· /build/build.sh

(-0, +9)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 10:43:33 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=c2ea4be0d79891290dc54afa7c75d5580c0162d1 https://devapps.diality.us/changelog/scripts?cs=c2ea4be0d79891290dc54afa7c75d5580c0162d1 Dara Navaei committed c2ea4be on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added set build variables function

· /build/build.sh

(-0, +1)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 10:39:05 -0700 Dara Navaei https://devapps.diality.us/changelog/scripts?cs=8123d25c30e5758a56234c634143c59315cade1b https://devapps.diality.us/changelog/scripts?cs=8123d25c30e5758a56234c634143c59315cade1b Dara Navaei committed 8123d25 on branch master, DEN-14294-UI-BN-S84 and 14 more in scripts Added support scripts into the build script

· /build/build.sh

(-7, +16)

| History

| Source

| Diff

]]> Mon, 27 Apr 2020 09:38:25 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-2236-1 https://devapps.diality.us/cru/UI-DEN-2236-1 Behrouz NematiPour Closed UI-DEN-2236-1 ]]> Mon, 27 Apr 2020 09:34:10 -0700 https://devapps.diality.us/cru/UI-DEN-2236-1 https://devapps.diality.us/cru/UI-DEN-2236-1 plucia  (deleted user) finished reviewing UI-DEN-2236-1 UI-DEN-2236_UI 100% Coverage of the Application Software ]]> Mon, 27 Apr 2020 09:33:56 -0700 plucia https://devapps.diality.us/cru/UI-DEN-2236-1/#c1706 https://devapps.diality.us/cru/UI-DEN-2236-1/#c1706 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-2236-1

RESOLVED

Hey Peter,
Thanks for the comments and all the testing .
This function doesn't mean to be used the way you tested it.
But anyway I came up with a better solution.

def partition(vString, vPart, vRightDirection=True):
    return [vString[i: i + vPart] for i in range(0, len(vString), vPart)][::-1 if vRightDirection else 1]

Actually my first thought was not correct on how this portion of the code should work.

def partition_orig(vString, vPart, vRightDirection = True):
    if vRightDirection:
        list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)]
    else:
        list = [vString[i : i + vPart] for i in range(0, len(vString), vPart)]
    return list


def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

print(partition_orig("TESTING123", 3))
print(partition_2("TESTING123", 3))

                  

Outputs:

['123', 'ING', 'EST', '']
['123', 'ING', 'EST', 'T']

whereas

def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart] for i in range(0, len(vString), vPart)]

outputs

['321', 'GNI', 'TSE', 'T']

I think you're saying you want to do the second one right? I think that would be better too!

Edit: Also I don't think you need the mString because in python immutable types (e.g. string, number, tuple) behave like call by value

I came out with the solution below :

def partition1(vString, vPart, vRightDirection=True):
mString = vString
if vRightDirection:
mString = vString[::-1]
else:
mString = vString
list = [mString[i: i + vPart] for i in range(0, len(mString), vPart)]
return list

if _name_ == "_main_":
vString = "TESTING"
vPart = 3

list = partition1(vString, vPart, True)
print(list)


list = partition1(vString, vPart, False)
print(list)

// ----- Output ----- :
['GNI', 'TSE', 'T']
['TES', 'TIN', 'G']

which is exactly what I want.
I'm gonna push changes if you agree.