BN approvees

BN approves

Added the function for device and VM

home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

where is the rejection.conf?
I don't see that in the CR.

RESOLVED

RESOLVED

RESOLVED

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

RESOLVED

RESOLVED

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

Stepnames variable is the list of objects (i.e concentrate,Installation,self tests)

Standard and advanced mode differ by getting the value from the system.conf file

What is 2?
What was 1?

Added the variable for the path

Getting the text from rejection.conf

Added for different test case for this test case it is not used

We have one parent object, and different values are defined by different ID by using findObjectByID

In another CR, this is a variable ([1] Request is ....).
After the comment is addressed there, maybe it can be used here.

Please provide an example of what the stepnames variable contains.
How do you ensure that the requested index is always available and that the code does not fail?

Why do we use findObjectByID and do not define it in then names.py?

Make this a variable, and it will also differ on the device or the DevTest VM.

Too general.
What is the usecase?

Now added the wait 6 min

when running I am stuck here for 10 min which and does not hit this condition... I think we are missing the global vitalsrequest at the top of this block

Initialize the vital request

vitalsrequest = None

corrected the invalid syntax and added the space between the function

Added before the pre treatment page

when is goes through here. the page is stuck on the feature configuration page... Please do the check before going into pre treatment so the flow does not get messed up.