okay will do

okay acknowledged

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

updated

this method removed but updated elsewhere

updated

this was existing code.. Updated to use the DeviceController and made updates accordingly. And Tested and still works

updated

updated

updated

added

the content for each page is now set to this container which will handle the margins for the container so all componenets using the SettingsBase will have the same margins and I do not have to specify them left, right, bottom in each of them.. I have done the same thing for other components that act as a container

added comment

updated

updated and added to fonts

updated logic so the grid view has an equal number of rows depending on the total number of visible items.

Before row count was hard coded to 6 so if there was ex. 8 items the left column would show 6 and the right 2.. Updated so the gridview will look as even as possible.

I hard coded the column to 2 columns since the design has 2 columns and added logic to the row count to make the 2 columns equal

changed to int

address cr comments

· /sources/device/DeviceController.cpp	(-0, +67)	| History	| Source	| Diff
· /sources/device/DeviceController.h	(-0, +3)	| History	| Source	| Diff
· /sources/device/DeviceError.cpp	(-0, +1)	| History	| Source	| Diff
· /sources/device/DeviceError.h	(-0, +1)	| History	| Source	| Diff
· /sources/device/DeviceGlobals.h	(-0, +9)	| History	| Source	| Diff
· /sources/device/DeviceModels.cpp	(-0, +39)	| History	| Source	| Diff
· /sources/device/DeviceModels.h	(-0, +37)	| History	| Source	| Diff
· /sources/device/DeviceView.cpp	(-0, +46)	| History	| Source	| Diff
· /sources/device/DeviceView.h	(-0, +4)	| History	| Source	| Diff
· /sources/gui/qml/components/HeaderBar.qml	(-5, +5)	| History	| Source	| Diff
· /sources/gui/qml/compounds/LabelUnitContainer.qml	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/ConfirmDialog.qml	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/globals/Fonts.qml	(-0, +8)	| History	| Source	| Diff
· /sources/gui/qml/pages/settings/SettingsBase.qml	(-2, +2)	| History	| Source	| Diff
· /sources/gui/qml/pages/settings/SettingsDateTime.qml	(-2, +17)	| History	| Source	| Diff
… 5 more files in changeset.

]]> Thu, 13 Nov 2025 11:09:21 -0800 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1/#c25134 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1/#c25134 Nicholas Ramirez replied to Behrouz NematiPour in LEAHI-APPLICATION-LDT-2727-1

This works. A few other qml files use this version of the import

👍 Will do all these in the enhancement story

Why did the logic change?
The order should be to fill in the first column, then go to the next, and it should not be by row.

why the rowcount is real?

IMPORTANT!!!
Please test this on the device.

For signals and slots as we tlaked use blocks of

onSomething: {
   aFunctionCall()
}

Unless there are multiple similar calls that need alignment in one line.

Why exposed?
Shouldn't the SettingsBase decide where the children must anchor, or locate?

Every time you use " * someValue ", please add a comment explaining why.
@100, @101, @102 as well.

Can you help me understand why we did not use the DeviceController attribute to call the datetime set script?
Or modify this function to use that design?