addark mode

· /sources/gui/qml/components/NotificationBar.qml	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/compounds/AutoStepController.qml	(-3, +5)	| History	| Source	| Diff
· /sources/gui/qml/compounds/InstructionView.qml	(-6, +6)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/AlarmDialog.qml	(-24, +27)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/AlarmListDialog.qml	(-5, +7)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/watersample/WaterSamplePage.qml	(-6, +6)	| History	| Source	| Diff
· /sources/gui/qml/globals/Colors.qml	(-1, +9)	| History	| Source	| Diff

]]> Thu, 04 Sep 2025 09:42:10 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Dara Navaei Closed LEAHI-APPLICATION-LDT-1788-1 ]]> Thu, 04 Sep 2025 09:41:40 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Dara Navaei started review LEAHI-APPLICATION-LDT-1788-1 ]]> Wed, 13 Aug 2025 18:07:50 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Behrouz NematiPour Closed LEAHI-APPLICATION-LDT-1788-1 ]]> Wed, 13 Aug 2025 17:09:31 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Behrouz NematiPour and Stephen Quong finished reviewing LEAHI-APPLICATION-LDT-1788-1 LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design ]]> Wed, 13 Aug 2025 16:11:41 -0700 Stephen Quong https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1/#c23762 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1/#c23762 Stephen Quong replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-1788-1

RESOLVED

RESOLVED

RESOLVED

BN: RESOLVED

BN: RESOLVED

updated

updated

updated

as discussed to add the space after the parenthesis. updated all instances

I agree with this comment, to make the code fit in a shorter vertical area.
Please use the Bjarne Stroustrup everywhere and be consistent:

if () {
}
else {
}

Stephen Quong
Please let's do that only for the long template-based iterator types, and not for all the variables.

And agree with using const and also & when applicable.

Remove leading and trailing spaces in if conditionals to keep style consistent.

Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable.

Change to match other beginning { style.

Change to match other beginning { style.

Change to match above beginning { style.

RESOLVED.

RESOLVED.

RESOLVED.

updated to parse and do nothing

removed

revert this too

revert

you have been removed

RESOLVED.