· /alarmMapping.sh	(-1, +1)	| History	| Source	| Diff
· /cho.sh	(-1, +1)	| History	| Source	| Diff
· /cppcheck.sh	(-1, +1)	| History	| Source	| Diff
· /cr_objectives.sh	(-1, +1)	| History	| Source	| Diff
· /imake.sh	(-1, +1)	| History	| Source	| Diff
· /main.cpp	(-2, +2)	| History	| Source	| Diff
· /remove-exra-emptylines.sh	(-1, +1)	| History	| Source	| Diff
· /sources/AlarmGenerator.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/AlarmGenerator.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationController.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.h	(-1, +1)	| History	| Source	| Diff
· /sources/MainTimer.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/MainTimer.h	(-1, +1)	| History	| Source	| Diff
… 598 more files in changeset.

]]> Tue, 08 Aug 2023 14:28:09 -0700 Dara Navaei https://devapps.diality.us/changelog/application?cs=ec31f94081864aec8b48a3cfa1e0aea80619714c https://devapps.diality.us/changelog/application?cs=ec31f94081864aec8b48a3cfa1e0aea80619714c Dara Navaei committed ec31f94 on branch master, @Environement_Swith and 109 more in application Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /sources/ApplicationController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.h	(-1, +1)	| History	| Source	| Diff
· /sources/gui/GuiController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/gui/GuiController.h	(-1, +1)	| History	| Source	| Diff
· /sources/main.h	(-1, +1)	| History	| Source	| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-20, +14)	| History	| Source	| Diff
· /sources/storage/Logger.h	(-1, +1)	| History	| Source	| Diff
· /sources/storage/Settings.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/storage/Settings.h	(-1, +1)	| History	| Source	| Diff
· /sources/view/hd/data/VTreatmentRanges.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/view/hd/data/VTreatmentRanges.h	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VAdjustmentAlarmVolume.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VAdjustmentAlarmVolume.h	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VDuetRoWaterDG.cpp	(-1, +1)	| History	| Source	| Diff

]]> Tue, 08 Aug 2023 13:45:12 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 vduong  (deleted user) Closed UI-DEN-15833-10 ]]> Tue, 08 Aug 2023 13:44:03 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour and Tiffany Mejia finished reviewing UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> Tue, 08 Aug 2023 11:46:32 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour added jpaguio  (deleted user) to UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> Sun, 06 Aug 2023 19:54:26 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 msuleiman  (deleted user) finished reviewing UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> Sun, 06 Aug 2023 19:53:12 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 msuleiman  (deleted user) joined UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> Sun, 06 Aug 2023 18:41:07 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour started review UI-DEN-15833-10 ]]> Sun, 06 Aug 2023 18:20:40 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/application?cs=0eb3d05f90d7ed90eadfab6c0c1db76fa2a70fb6 https://devapps.diality.us/changelog/application?cs=0eb3d05f90d7ed90eadfab6c0c1db76fa2a70fb6 Behrouz NematiPour committed 0eb3d05 on branch master, @Environement_Swith and 110 more in application DEN-15487: Updated - UI: POST: UI needs to report an error if the configuration files, or parameter(s) are missing.

DEN-16104: UI: Reorder the sequence of the messages in POST from UI to HD

· /sources/ApplicationController.cpp	(-36, +64)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-5, +5)	| History	| Source	| Diff
· /sources/ApplicationPost.cpp	(-16, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.h	(-5, +11)	| History	| Source	| Diff
· /sources/gui/GuiController.cpp	(-4, +4)	| History	| Source	| Diff
· /sources/gui/GuiController.h	(-2, +2)	| History	| Source	| Diff
· /sources/storage/Logger.h	(-0, +1)	| History	| Source	| Diff
· /sources/storage/Settings.cpp	(-7, +17)	| History	| Source	| Diff
· /sources/storage/Settings.h	(-3, +5)	| History	| Source	| Diff
· /sources/view/hd/data/VTreatmentRanges.cpp	(-5, +3)	| History	| Source	| Diff
· /sources/view/hd/data/VTreatmentRanges.h	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VAdjustmentAlarmVolume.cpp	(-2, +5)	| History	| Source	| Diff
· /sources/view/settings/VAdjustmentAlarmVolume.h	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VDuetRoWaterDG.cpp	(-2, +6)	| History	| Source	| Diff

]]> Tue, 01 Aug 2023 18:23:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18361 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18361 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Changed

Added.

Added.

Changed based on how GuiView handles the connection from a created-in-QML object.

Updated with changes per CR request

· /sources/ApplicationController.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/gui/GuiController.cpp	(-0, +9)	| History	| Source	| Diff
· /sources/gui/GuiController.h	(-0, +3)	| History	| Source	| Diff
· /sources/storage/Settings.cpp	(-8, +7)	| History	| Source	| Diff
· /sources/view/hd/data/VTreatmentRanges.cpp	(-2, +14)	| History	| Source	| Diff

]]> Fri, 28 Jul 2023 05:00:56 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18307 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18307 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

• the API is just emitting the signal
• and is not responsible for the usage.
• any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)

Please move to ApplicationController class.

please check, lists are not empty.
can be checked by private member variable:

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

add an empty line before and after

please align
SIGNAL(did
SLOT( on

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}

thanks