The branch is not going to be merged.
But the code needs to be kept.

· /alarmMapping.sh	(-1, +1)	| History	| Source	| Diff
· /cho.sh	(-1, +1)	| History	| Source	| Diff
· /cppcheck.sh	(-1, +1)	| History	| Source	| Diff
· /cr_objectives.sh	(-1, +1)	| History	| Source	| Diff
· /imake.sh	(-1, +1)	| History	| Source	| Diff
· /main.cpp	(-2, +2)	| History	| Source	| Diff
· /remove-exra-emptylines.sh	(-1, +1)	| History	| Source	| Diff
· /sources/AlarmGenerator.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/AlarmGenerator.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationController.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.h	(-1, +1)	| History	| Source	| Diff
· /sources/MainTimer.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/MainTimer.h	(-1, +1)	| History	| Source	| Diff
… 598 more files in changeset.

]]> Tue, 26 Sep 2023 12:46:04 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 vduong  (deleted user) Closed UI-DEN-16249-2 ]]> Tue, 26 Sep 2023 12:32:54 -0700 https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 Behrouz NematiPour and Tiffany Mejia finished reviewing UI-DEN-16249-2 UI-DEN-16249_UI VD S104 P1B StatusIndicator BT/Wifi [ ready ] ]]> Mon, 11 Sep 2023 16:10:41 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-1 https://devapps.diality.us/cru/UI-DEN-16335-1 Behrouz NematiPour Closed UI-DEN-16335-1 ]]> Mon, 11 Sep 2023 16:10:32 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-1/#c18893 https://devapps.diality.us/cru/UI-DEN-16335-1/#c18893 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-16335-1

RESOLVED

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

· /main.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationController.h	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/ApplicationPost.h	(-1, +1)	| History	| Source	| Diff
· /sources/bluetooth/BluetoothInterface.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/bluetooth/BluetoothInterface.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.h	(-2, +2)	| History	| Source	| Diff
· /sources/canbus/MessageGlobals.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/MessageInterpreter.cpp	(-2, +2)	| History	| Source	| Diff
· /sources/device/DeviceController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/device/DeviceController.h	(-1, +1)	| History	| Source	| Diff
· /sources/device/DeviceModels.h	(-1, +1)	| History	| Source	| Diff
· /sources/device/DeviceView.cpp	(-1, +1)	| History	| Source	| Diff
… 42 more files in changeset.

]]> Wed, 06 Sep 2023 11:32:28 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16335-1 https://devapps.diality.us/cru/UI-DEN-16335-1 vduong  (deleted user) started review UI-DEN-16335-1 ]]> Wed, 06 Sep 2023 06:22:51 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16335-1 https://devapps.diality.us/cru/UI-DEN-16335-1 vduong  (deleted user) Closed UI-DEN-16335-1 ]]> Tue, 05 Sep 2023 16:46:15 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-1/#c18842 https://devapps.diality.us/cru/UI-DEN-16335-1/#c18842 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16335-1

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Done.

Per our call, you have agreed to leave it above in this location. No change in location

We clarify this thread with a call.

This is no longer applicable due to the changes from our conversation.

I made the changes based on the call we had.

Modify the logged message to better indicate the bluetooth connection and paired status

· /sources/bluetooth/BluetoothInterface.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/view/settings/VBluetooth.cpp	(-3, +4)	| History	| Source	| Diff

]]> Tue, 05 Sep 2023 15:08:50 -0700 Vy <vduong@sunriselabs.com> https://devapps.diality.us/changelog/application?cs=e3cfef345710717229407f105a0cba1bb479b9d5 https://devapps.diality.us/changelog/application?cs=e3cfef345710717229407f105a0cba1bb479b9d5 Vy <vduong@sunriselabs.com> committed e3cfef3 on branch master, @Environement_Swith and 94 more in application DEN-16319: Updated - UI log does not record blood pressure cuff bluetooth pairing

Remove unused bt model constructors in MBluetooth

Make use of the devicePair member variable, removing added isPaired

Remove pairing getter function

· /sources/bluetooth/BluetoothInterface.cpp	(-19, +4)	| History	| Source	| Diff
· /sources/bluetooth/BluetoothInterface.h	(-1, +0)	| History	| Source	| Diff
· /sources/model/settings/MBluetooth.cpp	(-24, +0)	| History	| Source	| Diff
· /sources/model/settings/MBluetooth.h	(-17, +0)	| History	| Source	| Diff
· /sources/view/settings/VBluetooth.cpp	(-6, +2)	| History	| Source	| Diff

]]> Tue, 05 Sep 2023 14:09:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16335-1/#c18829 https://devapps.diality.us/cru/UI-DEN-16335-1/#c18829 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16335-1

not clear what it means.

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

where do you use this ctor?