BN approves

BN approves

BN approves

Updated the test script with TDTreaRinsebackStates

As per suggestion using TDTreaRinsebackStates in test script

I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

i am good with the implementaiton

i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value

The states that need .value come from the td_defs that inherit from DialinEnum, and the ones that don't have .value come from the ui_defs, which are simple classes, so they don't need .value since those do not support metadata.
The UI_defs seem to be what I think aren't maintained anymore and last time updated was the 21 months ago.

Anything we want shall be available in the td_defs.
as an example:

# TDTreatmentStates.TREATMENT_RINSEBACK_STATE sub states
@unique
class TDTreaRinsebackStates(DialinEnum):
    RINSEBACK_STOP_INIT_STATE           = 0                     # Start state (stopped) of the rinseback sub-mode state machine
    RINSEBACK_RUN_STATE                 = 1                     # Rinseback running state of the rinseback sub-mode state machine
    RINSEBACK_PAUSED_STATE              = 2                     # Rinseback paused state of the rinseback sub-mode state machine
    RINSEBACK_STOP_STATE                = 3                     # Rinseback stopped (done) state of the rinseback sub-mode state machine
    RINSEBACK_RUN_ADDITIONAL_STATE      = 4                     # Additional rinseback volume (10 mL) state of the rinseback sub-mode state machine
    RINSEBACK_RECONNECT_PATIENT_STATE   = 5                     # Rinseback patient reconnect state of the rinseback sub-mode state machine
    NUM_OF_RINSEBACK_STATES             = 6                     # Number of rinseback sub-mode states

We should follow the same rule in the simulators and plugins.

Nicholas Ramirez I still need your feedback and correct me if I am wrong.

Nicholas Ramirez Please investigate the Dial-In code.

Oh, what is the interval of the lambda call?
I have never used it this way.
Not sure if that is a good or bad idea.
Did we check the performance, or if it blocks the test?
Nicholas Ramirez Resolve if you are fine with the implementation.

RESOLVED

we can make a function to just

def rinsebackrequest_Check():
return rinsebackrequest == 8

if this works better? but well have alot more functions elsewhere. Let us know Behrouz NematiPour but the majority of the test cases do indeed use the lambda

we the lamba because we are using the waitFor() to wait for this condition to be true.

waitFor() calls the lambda multiple times until it returns True or the timeout expires.

Thanks for providing the definition of the lambda.
My main question is, why lambda?
What is that condition in this lambda (what is rinsebackrequest == 8)?
If that has a common use case, better to be a function?

Nicholas Ramirez Could you please check why that is, what the difference is between the two, and whether there are any inconveniences with Dial-In we need to take care of?

Does this work?
Have you tested it?
It seems like while all are using equal, they should overwrite the previous one.

It is just a preference; if you can't find a way, that's fine to leave it as it was.

Lambda is used here to pass a condition as a function that can be evaluated repeatedly without writing a full function definition.

Added the separate line for each test cases, using \ getting error

For TX states does not require the ".value"

For TXStates.RINSEBACK_STOP_INIT_STATE does not require ".value"

can each tst_ be on a line, and break these down into lines with some \ or something?

Please shortly explain the lambda use case her.

Same comment for the enum " .value " for the rest of the calls here.

doesn't the TXStates.RINSEBACK_STOP_INIT_STATE need " .value " like the other enums?

What is this variable?
If that is the rejection reason ID: 1, I don't think we should use it this way?
We need to find the reason message/text for the rejection by the rejection ID.
If that is the only case, let me know where it is used and why only one case was tested, rather than testing the rest.
The entire rejection system needs to be tested in a separate test suite if we have not already done so.

Payload has been updated and test script is working