This is a list of all comments for DD-LDT-1473-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Ultrafilteration.c
Revision Comment by Sean Nash on 27 July 2025, 21:49 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23161

  Remove extra blank line.

  Reply by Vinayakam Mani on 28 July 2025, 13:59
  > Done.

Revision Comment by Sean Nash on 27 July 2025, 21:55 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23163

  Where did 5 second period come from?

  Reply by Vinayakam Mani on 28 July 2025, 14:00
  > With the updated FPGA logic for continuous flow rate, doesn't
  > need this variable anymore.

Revision Comment by Sean Nash on 27 July 2025, 21:50 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23162

  Capitalize the p.

  Reply by Vinayakam Mani on 28 July 2025, 14:00
  > With the updated FPGA logic for continuous flow rate, doesn't
  > need this variable anymore.

Revision Comment by Sean Nash on 27 July 2025, 21:59 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23165

  Are we dosing UF in spurts like concentrates?

  Reply by Vinayakam Mani on 28 July 2025, 14:00
  > With the updated FPGA logic for continuous flow rate, doesn't
  > need this variable anymore.

Revision Comment by Sean Nash on 27 July 2025, 22:02 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23166

  Looks like you are calculating iteration in "mL/5sec", not
  "mL/sec".

  Reply by Vinayakam Mani on 28 July 2025, 14:00
  > With the updated FPGA logic for continuous flow rate, doesn't
  > need this variable anymore.

Revision Comment by Sean Nash on 27 July 2025, 22:04 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23167

  Isn't there a common override function that does this?

  Reply by Vinayakam Mani on 28 July 2025, 14:00
  > Done

----------------------------------------
File: firmware/App/Controllers/Ultrafilteration.h
Revision Comment by Sean Nash on 27 July 2025, 21:47 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23159

  It's "filtration", not "filteration".  Misspelled throughout.

  Reply by Vinayakam Mani on 28 July 2025, 13:59
  > Done.

Revision Comment by Sean Nash on 27 July 2025, 21:49 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23160

  Capitalize the p in per.

  Reply by Vinayakam Mani on 28 July 2025, 14:08
  > Done.

----------------------------------------
File: firmware/App/Controllers/PistonPumpControl.h
Revision Comment by Sean Nash on 28 July 2025, 14:03 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23203

  Remove extra blank line.

  Reply by Vinayakam Mani on 28 July 2025, 14:15
  > Done.

----------------------------------------
File: firmware/App/Controllers/Ultrafiltration.c
Revision Comment by Sean Nash on 29 July 2025, 22:23 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23254

  Consider doing this in update compensated rate function (only
  once every 2 minutes when rate actually changes).

----------------------------------------
File: firmware/App/Services/AlarmMgmtDD.c
Revision Comment by Sean Nash on 01 August 2025, 16:05 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23451

  Is this safe to enable now?

  Reply by Vinayakam Mani on 01 August 2025, 16:34
  > I have introduced two additional build flags in 'DDCommon.h'
  > (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop
  > triggering alarms due to hardware support etc., so. it should
  > be safe for now. if still any specific alarms triggers, will
  > try to disable those alarms.

Revision Comment by Sean Nash on 01 August 2025, 16:06 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23452

  2 blank lines above and below test support banners.

  Reply by Vinayakam Mani on 01 August 2025, 16:42
  > Done.

----------------------------------------
File: firmware/App/Controllers/Valves.h
Revision Comment by Michael Garthwaite on 04 August 2025, 09:34 
https://devapps.diality.us/cru/DD-LDT-1473-1#c23484

  Where did this valve enum go?

  Reply by Vinayakam Mani on 04 August 2025, 09:44
  > it is moved to DDDef.h, UI team is looking for this mapping
  > for their (diagnostics page) development.

    Reply by Michael Garthwaite on 04 August 2025, 10:07
    > Thanks. Resolved


---

ID: DD-LDT-1473-1 https://devapps.diality.us/cru/DD-LDT-1473-1

Title: DD-LDT-1473_Ultrafiltration DD
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Daniel Ho