This is a list of all comments for DD-LDT-319-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModePostGenDialysate.c
Revision Comment by Sean Nash on 21 April 2025, 10:19 
https://devapps.diality.us/cru/DD-LDT-319-1#c21911

  Align comment.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done. somehow I see its all aligned in CCS editor.

Revision Comment by Sean Nash on 21 April 2025, 10:19 
https://devapps.diality.us/cru/DD-LDT-319-1#c21912

  postGenDialysateState is an input.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done.

Revision Comment by Sean Nash on 21 April 2025, 10:20 
https://devapps.diality.us/cru/DD-LDT-319-1#c21913

  Add a message sent detail.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done.

----------------------------------------
File: firmware/App/Modes/ModePreGenDialysate.c
Revision Comment by Sean Nash on 21 April 2025, 10:17 
https://devapps.diality.us/cru/DD-LDT-319-1#c21908

  Align comment.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done. Somehow its aligned in CCS editor.

Revision Comment by Sean Nash on 21 April 2025, 10:17 
https://devapps.diality.us/cru/DD-LDT-319-1#c21909

  preGenDialysateState is an input.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done.

Revision Comment by Sean Nash on 22 April 2025, 13:15 
https://devapps.diality.us/cru/DD-LDT-319-1#c21971

  Same as Gen Dialysate - this should be else if and switch
  statement should be in a final else.

  Reply by Vinayakam Mani on 22 April 2025, 14:06
  > Done.

Revision Comment by Sean Nash on 21 April 2025, 10:18 
https://devapps.diality.us/cru/DD-LDT-319-1#c21910

  preGenDialysateState is an input.

  Reply by Vinayakam Mani on 21 April 2025, 17:35
  > Done.

----------------------------------------
File: firmware/App/Controllers/DialysatePumps.c
Revision Comment by Sean Nash on 21 April 2025, 10:08 
https://devapps.diality.us/cru/DD-LDT-319-1#c21906

  Add new @param.

  Reply by Vinayakam Mani on 21 April 2025, 17:34
  > Done.

----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 22 April 2025, 13:08 
https://devapps.diality.us/cru/DD-LDT-319-1#c21968

  I think these two conditions above the switch statement should
  end the state processing.  
  So the second condition should be an else if and combined i.e.
  if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE )
  && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
  And then another else where the switch statement should go.
  Hydraulic chamber and updating treatment settings should maybe
  be moved above all of this so they always happen.

  Reply by Vinayakam Mani on 22 April 2025, 14:07
  > Done.

Revision Comment by Sean Nash on 22 April 2025, 13:14 
https://devapps.diality.us/cru/DD-LDT-319-1#c21970

  stop should be capitalized.

  Reply by Vinayakam Mani on 22 April 2025, 14:07
  > Done.

Revision Comment by Sean Nash on 22 April 2025, 13:14 
https://devapps.diality.us/cru/DD-LDT-319-1#c21969

  Remove extra blank line.

  Reply by Vinayakam Mani on 22 April 2025, 14:07
  > Done.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 21 April 2025, 10:13 
https://devapps.diality.us/cru/DD-LDT-319-1#c21907

  Add a condition that Dialin user is not logged into DD.  If
  tester is logged in, we want to allow tester to set mode to
  whatever they want.

  Reply by Vinayakam Mani on 21 April 2025, 17:35
  > Done.

----------------------------------------
File: firmware/App/Services/TDInterface.c
Revision Comment by Sean Nash on 22 April 2025, 08:57 
https://devapps.diality.us/cru/DD-LDT-319-1#c21957

  Signal Pre Gen mode and let it request standby mode.

  Reply by Sean Nash on 22 April 2025, 10:33
  > Want Pre Gen mode  state machine to handle the mode change -
  > so request function should set a flag that the state machine
  > will act on in next pass.

    Reply by Vinayakam Mani on 22 April 2025, 13:18
    > Done

Revision Comment by Sean Nash on 22 April 2025, 08:56 
https://devapps.diality.us/cru/DD-LDT-319-1#c21956

  Should signal Gen Dialysate mode and let it request transition
  to standby.

  Reply by Sean Nash on 22 April 2025, 10:34
  > Want Gen Dialysate mode state machine to handle the mode
  > change - so request function should set a flag that the state
  > machine will act on in next pass.

    Reply by Vinayakam Mani on 22 April 2025, 11:43
    > Done.


---

ID: DD-LDT-319-1 https://devapps.diality.us/cru/DD-LDT-319-1

Title: DD-LDT-319_Basic Dialysis Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Daniel Ho