This is a list of all comments for DD-LDT-815-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 03 July 2025, 12:12 
https://devapps.diality.us/cru/DD-LDT-815-1#c22720

  Mark these questions with TODO to aid in follow-up.

  Reply by Vinayakam Mani on 03 July 2025, 12:45
  > Done.

----------------------------------------
File: firmware/App/Modes/ModeFault.c
Revision Comment by Sean Nash on 03 July 2025, 11:54 
https://devapps.diality.us/cru/DD-LDT-815-1#c22716

  Keep a blank line between banner and variables.

  Reply by Vinayakam Mani on 03 July 2025, 12:42
  > Done.

Revision Comment by Sean Nash on 03 July 2025, 12:09 
https://devapps.diality.us/cru/DD-LDT-815-1#c22718

  Is this complete state needed?  I don't see how we even get
  here.

  Reply by Vinayakam Mani on 03 July 2025, 12:41
  > Removed.

Revision Comment by Sean Nash on 03 July 2025, 12:10 
https://devapps.diality.us/cru/DD-LDT-815-1#c22719

  Reset to start state in default.

  Reply by Vinayakam Mani on 03 July 2025, 12:41
  > Done.

Revision Comment by Sean Nash on 03 July 2025, 12:08 
https://devapps.diality.us/cru/DD-LDT-815-1#c22717

  Add a TODO comment to complete when NV POST implemented.

  Reply by Vinayakam Mani on 03 July 2025, 12:41
  > Done.


---

ID: DD-LDT-815-1 https://devapps.diality.us/cru/DD-LDT-815-1

Title: DD-LDT-815_Stop State DD
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Daniel Ho