This is a list of all comments for DD-LDT-880-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Sean Nash on 18 July 2025, 13:31 
https://devapps.diality.us/cru/DD-LDT-880-1#c22982

  Recommend 0.0F if control interval is short (like 3 sec) so we
  don't introduce an initial error to PI controller.

  Reply by Vinayakam Mani on 21 July 2025, 11:09
  > Redefined delta temperature to 0.5F to go over the target
  > temperature (i.e., Target Temp + 0.5) to compensate with
  > reduced Feedforward control. We will adjust this as needed
  > based on the testing.

----------------------------------------
File: firmware/App/Monitors/Temperature.c
Revision Comment by Sean Nash on 18 July 2025, 13:25 
https://devapps.diality.us/cru/DD-LDT-880-1#c22981

  If timer set is initialized to FALSE, shouldn't the timer be
  initialized to zero?

  Reply by Vinayakam Mani on 21 July 2025, 11:12
  > Done.

Revision Comment by Sean Nash on 18 July 2025, 13:17 
https://devapps.diality.us/cru/DD-LDT-880-1#c22980

  If you use timer functions to manage sample interval, it is
  possible to have 10ms jitter.  
  Priority task is initiated every 10ms very accurately, but when
  code is executed within any given priority task interval can
  vary with position of the code in the task sequence and varying
  amount of time taken to complete each part of the task sequence
  from one interval to the next.  So it is possible that
  sometimes you could have the ms timer saying something like
  59ms when you would expect 60ms (because it's been 6 times
  through the 10ms task).  In cases like this, you would wait for
  the next task (so 10ms later).
  I think it's safer to use a task interval counter and
  multiplying the counter by the task interval (10ms).

  Reply by Vinayakam Mani on 21 July 2025, 11:12
  > Done.


---

ID: DD-LDT-880-1 https://devapps.diality.us/cru/DD-LDT-880-1

Title: DD-LDT-880_Dialysate Temperature DD 1
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Daniel Ho