This is a list of all comments for DD-LEAH-224-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BalancingChamber.c
Revision Comment by Sean Nash on 24 February 2025, 08:50 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21542

  I would consider switching only to be the abnormal case, so
  better to say != TRUE.

  Reply by Vinayakam Mani on 24 February 2025, 10:40
  > Done.

Revision Comment by Sean Nash on 24 February 2025, 08:52 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21543

  Why is there a max pressure?  If looking for a drop, why not
  just a <= min?

  Reply by Vinayakam Mani on 24 February 2025, 10:40
  > Done.

Revision Comment by Sean Nash on 24 February 2025, 09:02 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21546

  Why do we need 2 flags for pressure drop?  Seems like you only
  use one at a time.

  Reply by Vinayakam Mani on 24 February 2025, 10:40
  > Done.

----------------------------------------
File: firmware/App/Monitors/Pressure.c
Revision Comment by Sean Nash on 24 February 2025, 09:37 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21550

  Still needed?

  Reply by Vinayakam Mani on 24 February 2025, 11:23
  > Removed. Done.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 24 February 2025, 12:39 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21563

  Update @return comment.

  Reply by Vinayakam Mani on 24 February 2025, 12:48
  > Done.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.h
Revision Comment by Sean Nash on 24 February 2025, 08:54 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21544

  What does status mean?  If returning a BOOL, I assume TRUE
  still indicates dosing completed so why change the function
  name?

  Reply by Vinayakam Mani on 24 February 2025, 11:01
  > Done.

----------------------------------------
File: firmware/App/Monitors/Level.c
Revision Comment by Sean Nash on 24 February 2025, 09:35 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21549

  Remove these blank lines.

  Reply by Vinayakam Mani on 24 February 2025, 11:15
  > Done.

----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 24 February 2025, 09:34 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21547

  Recommend removing this.

  Reply by Vinayakam Mani on 24 February 2025, 11:11
  > Done.

Revision Comment by Sean Nash on 24 February 2025, 09:34 
https://devapps.diality.us/cru/DD-LEAH-224-1#c21548

  Call transition function here instead.

  Reply by Vinayakam Mani on 24 February 2025, 11:12
  > Done.


---

ID: DD-LEAH-224-1 https://devapps.diality.us/cru/DD-LEAH-224-1

Title: DD-LEAH-224_FW DD Gear Pump Driver 1
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei