This is a list of all comments for DD-LEAH-230-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Sean Nash on 31 March 2025, 09:57 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21848

  Do we still need to support other versions?

  Reply by Vinayakam Mani on 02 April 2025, 17:19
  > Removed.

Revision Comment by Sean Nash on 31 March 2025, 09:58 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21849

  Can we remove these commented out #defines?

  Reply by Vinayakam Mani on 02 April 2025, 17:19
  > Done.

Revision Comment by Sean Nash on 31 March 2025, 10:00 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21850

  Do we still need test timing?  Can we remove?

  Reply by Vinayakam Mani on 02 April 2025, 17:19
  > Done.

Revision Comment by Sean Nash on 27 February 2025, 09:18 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21603

  Make literals floats explicitly (i.e. 800.0F / 1000.0F).

Revision Comment by Sean Nash on 31 March 2025, 10:01 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21851

  Remove this constant if not needed.

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > It's needed for heater monitoring. so, reserving it for
  > future.

Revision Comment by Sean Nash on 27 February 2025, 09:18 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21604

  4184.0F and (F32)SEC_PER_MIN

Revision Comment by Sean Nash on 31 March 2025, 10:05 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21852

  Should this be a constant?

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > Done.

Revision Comment by Sean Nash on 31 March 2025, 10:06 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21853

  Add a blank line between declarations and code.

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > Done.

Revision Comment by Sean Nash on 03 April 2025, 08:55 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21882

  Why 590?  Magic number - use #define.

  Reply by Vinayakam Mani on 03 April 2025, 09:29
  > Done.

Revision Comment by Sean Nash on 31 March 2025, 10:17 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21855

  Somewhere, we should be resetting some flags and FF value
  before we start a new control.

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > Done.

Revision Comment by Sean Nash on 31 March 2025, 10:09 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21854

  Remove support for other versions?

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > Removed.

Revision Comment by Sean Nash on 31 March 2025, 10:19 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21856

  This function is pretty long.  Can we make this FF calculation
  a separate function to call from here?

  Reply by Vinayakam Mani on 02 April 2025, 17:20
  > Done.

Revision Comment by Sean Nash on 31 March 2025, 10:20 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21857

  Should we change this back to target?

  Reply by Vinayakam Mani on 02 April 2025, 17:21
  > Done.

----------------------------------------
File: firmware/App/Controllers/Heaters.h
Revision Comment by Sean Nash on 31 March 2025, 09:53 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21847

  Indicate we are signaling a change in Qd here.

  Reply by Vinayakam Mani on 02 April 2025, 17:21
  > Done.

----------------------------------------
File: firmware/App/Drivers/TemperatureSensors.c
Revision Comment by Sean Nash on 31 March 2025, 09:41 
https://devapps.diality.us/cru/DD-LEAH-230-1#c21846

  Can we remove 19600?

  Reply by Vinayakam Mani on 02 April 2025, 17:21
  > Done.


---

ID: DD-LEAH-230-1 https://devapps.diality.us/cru/DD-LEAH-230-1

Title: DD-LEAH-230_FW DD Heaters Controller 1
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Daniel Ho