This is a list of all comments for DG-COMMON-FIX-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by pmontazemi on 27 March 2020, 09:35 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1531

  I wouldn't make or call these various modes of operation part
  of fill.

  Reply by Sean Nash on 27 March 2020, 10:39
  > SA doc led me to believe they were.  I had same initial
  > thought but I could not think of any other DG mode where we
  > would be doing these things.  We may be doing some things in
  > other modes that are similar to some of these states, but
  > they are different and I figure those other modes will have
  > their own states even if they are similar to some of these.
  > Fill appears to be the only mode where we are producing
  > dialysate.

    Reply by pmontazemi on 30 March 2020, 10:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by pmontazemi on 27 March 2020, 09:50 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1534

  Does HD have a Standby mode, as well?

  Reply by Sean Nash on 27 March 2020, 10:36
  > Yes.

    Reply by pmontazemi on 30 March 2020, 10:11
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 27 March 2020, 09:54 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1535

  What is this alarm for?

  Reply by Sean Nash on 27 March 2020, 10:35
  > We always throw a software fault if we find ourselves in an
  > invalid state.

    Reply by pmontazemi on 30 March 2020, 10:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by pmontazemi on 27 March 2020, 09:55 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1536

  Is this check solely based on communication over CAN or we are
  also checking electrically (HW config) that we are connected?

  Reply by Sean Nash on 27 March 2020, 10:32
  > I am currently unsure how we want to transition DG back and
  > forth between normal to solo modes.  I will discuss with
  > Systems team.

    Reply by pmontazemi on 30 March 2020, 10:13
    > I will call for a meeting with SYS/EE to get overall
    > clarification.

      Reply by Dara Navaei on 19 October 2023, 08:43
      > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/ModeSolo.c
Revision Comment by pmontazemi on 27 March 2020, 09:49 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1532

  Remove extra line.

  Reply by Sean Nash on 27 March 2020, 10:38
  > Done.

    Reply by pmontazemi on 30 March 2020, 10:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeSolo.h
Revision Comment by pmontazemi on 27 March 2020, 09:50 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1533

  I really like the name "Solo".

  Reply by Dara Navaei on 19 October 2023, 08:43
  > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/source/sys_main.c
Revision Comment by pmontazemi on 27 March 2020, 09:58 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1537

  What does init reservoirs mean? Perhaps change to wording that
  better hints the functionality?

  Reply by Sean Nash on 27 March 2020, 10:31
  > These are all calls to individual module initializer
  > functions at power up.

    Reply by pmontazemi on 30 March 2020, 10:15
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: RTC.c
Revision Comment by pmontazemi on 29 March 2020, 21:02 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1546

  OK, another great reason to add an alarm, here, no?

  Reply by Sean Nash on 30 March 2020, 08:31
  > Dara, I thought we got rid of this?  Maybe you did in your
  > branch?

    Reply by pmontazemi on 30 March 2020, 10:28
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by pmontazemi on 27 March 2020, 09:23 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1529

  What is causing this error? Don't we slow down the UF rate as
  we see it approaching the upper bound?

  Reply by Sean Nash on 27 March 2020, 10:47
  > This error is dealing with the requirement that we should not
  > be drawing more than 2500 mL/hour from a patient.

    Reply by pmontazemi on 30 March 2020, 10:07
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Drivers/InternalADC.c
Revision Comment by pmontazemi on 27 March 2020, 09:32 
https://devapps.diality.us/cru/DG-COMMON-FIX-1#c1530

  Do we have sensors supplied with +6 Vdc?

  Reply by Sean Nash on 27 March 2020, 10:45
  > There must be at least one sensor on 6V but I don't know
  > which sensor(s) they are.  I got these ADC channel
  > assignments from the DG HDD.

    Reply by pmontazemi on 30 March 2020, 10:08
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1

Title: DG-COMMON-FIX_Review
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 2 completed*)
     Dara Navaei   (*)
     pmontazemi   (*)