This is a list of all comments for DG-DEN-12845-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Switches.c
Revision Comment by Sean Nash on 20 May 2022, 15:51 
https://devapps.diality.us/cru/DG-DEN-12845-2#c12847

  Remove one of these blank lines.

  Reply by Dara Navaei on 13 June 2022, 09:09
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:05
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 May 2022, 15:52 
https://devapps.diality.us/cru/DG-DEN-12845-2#c12848

  Align comment.

  Reply by Dara Navaei on 13 June 2022, 09:09
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:05
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 May 2022, 15:54 
https://devapps.diality.us/cru/DG-DEN-12845-2#c12849

  Restore extra blank line.

  Reply by Dara Navaei on 13 June 2022, 09:09
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:05
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Switches.h
Revision Comment by Sean Nash on 20 May 2022, 15:50 
https://devapps.diality.us/cru/DG-DEN-12845-2#c12845

  Is this addtogroup doxygen redundant with above?

  Reply by Dara Navaei on 13 June 2022, 09:11
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 May 2022, 15:51 
https://devapps.diality.us/cru/DG-DEN-12845-2#c12846

  Shouldn't this be at end of header file?

  Reply by Dara Navaei on 13 June 2022, 09:11
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:06
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-12845-2 https://devapps.diality.us/cru/DG-DEN-12845-2

Title: DG-DEN-12845_SW Dev Sprint S71 Steve
Statement of Objectives:


State: Closed

Summary: 

Author: Steve Jarpe
Moderator: Steve Jarpe
Reviewers: (3 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     Dara Navaei
     Darren Cox