This is a list of all comments for DG-DEN-13786-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by Sean Nash on 24 October 2022, 10:48 https://devapps.diality.us/cru/DG-DEN-13786-1#c14599 Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed. Reply by wbracken on 24 October 2022, 14:07 > Change was made to get around earlier issues. Need > discussion on whether or not to change back. Reply by wbracken on 24 October 2022, 14:37 > Add TODO to comment. Reply by Sean Nash on 24 October 2022, 15:21 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeHeatDisinfect.c Revision Comment by Sean Nash on 24 October 2022, 10:53 https://devapps.diality.us/cru/DG-DEN-13786-1#c14603 Alphabetize (move toward top of includes). Reply by wbracken on 24 October 2022, 14:24 > Moved. Reply by Sean Nash on 24 October 2022, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 10:55 https://devapps.diality.us/cru/DG-DEN-13786-1#c14605 Remove blank line. Reply by wbracken on 24 October 2022, 14:16 > Removed Reply by Sean Nash on 24 October 2022, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 10:57 https://devapps.diality.us/cru/DG-DEN-13786-1#c14606 Remove blank line. Reply by wbracken on 24 October 2022, 14:23 > Removed. Reply by Sean Nash on 24 October 2022, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 10:58 https://devapps.diality.us/cru/DG-DEN-13786-1#c14607 Is this dead code? Can we remove? Reply by wbracken on 24 October 2022, 14:04 > Removed. Reply by Sean Nash on 24 October 2022, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 11:00 https://devapps.diality.us/cru/DG-DEN-13786-1#c14609 Use BOOL. And add a blank line after. And make following condition explicit (i.e. != TRUE). Reply by wbracken on 24 October 2022, 14:21 > Removed. Reply by Sean Nash on 24 October 2022, 15:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 11:01 https://devapps.diality.us/cru/DG-DEN-13786-1#c14610 Remove extra blank line. Reply by wbracken on 24 October 2022, 14:51 > Removed. Reply by Sean Nash on 24 October 2022, 15:18 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/TemperatureSensors.c Revision Comment by Sean Nash on 24 October 2022, 10:51 https://devapps.diality.us/cru/DG-DEN-13786-1#c14600 Magic #? Reply by wbracken on 24 October 2022, 14:06 > Done. Reply by Dara Navaei on 24 October 2022, 14:35 > This function has been refactored. Reply by Sean Nash on 24 October 2022, 15:21 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Heaters.c Revision Comment by Sean Nash on 24 October 2022, 10:40 https://devapps.diality.us/cru/DG-DEN-13786-1#c14593 Can we do s/w fault now? Reply by Dara Navaei on 24 October 2022, 10:42 > This is not a software fault. This has been addressed in > DEN-14166. Reply by Sean Nash on 24 October 2022, 10:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 October 2022, 10:42 https://devapps.diality.us/cru/DG-DEN-13786-1#c14594 Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)? Reply by Dara Navaei on 24 October 2022, 10:45 > In V3, when TRo is requested, the firmware send the value of > TDi. Reply by Sean Nash on 24 October 2022, 10:46 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialysateFlow.c Revision Comment by Sean Nash on 24 October 2022, 10:36 https://devapps.diality.us/cru/DG-DEN-13786-1#c14592 Remove comment. Reply by Dara Navaei on 24 October 2022, 14:30 > This file has been deleted. Reply by wbracken on 24 October 2022, 14:40 > This file has been removed. Reply by Sean Nash on 24 October 2022, 15:21 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/DGCommon.h Revision Comment by Sean Nash on 24 October 2022, 11:02 https://devapps.diality.us/cru/DG-DEN-13786-1#c14611 Why is RTC POST disabled? Reply by Dara Navaei on 24 October 2022, 13:43 > This build switch has been removed. Reply by Sean Nash on 24 October 2022, 15:22 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeChemicalDisinfect.c Revision Comment by Sean Nash on 24 October 2022, 10:52 https://devapps.diality.us/cru/DG-DEN-13786-1#c14601 Alphabetize - move toward top of includes. Reply by wbracken on 24 October 2022, 14:27 > Moved. Reply by Sean Nash on 24 October 2022, 15:20 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFlush.c Revision Comment by Sean Nash on 24 October 2022, 10:53 https://devapps.diality.us/cru/DG-DEN-13786-1#c14602 Alphabetize (move toward top of includes). Reply by wbracken on 24 October 2022, 14:26 > Moved. Reply by Sean Nash on 24 October 2022, 15:20 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-13786-1 https://devapps.diality.us/cru/DG-DEN-13786-1 Title: DG-DEN-13786_HD DG Dev S78 BB Statement of Objectives: State: Closed Summary: Author: wbracken Moderator: wbracken Reviewers: (3 active, 1 completed*) Dara Navaei (*) Sean Nash Michael Garthwaite dcox