This is a list of all comments for DG-DEN-14589-1.

Review Summary: No summary


----------------------------------------
File: RTC.c
Revision Comment by wbracken on 01 February 2023, 16:57 
https://devapps.diality.us/cru/DG-DEN-14589-1#c16284

  Alphabetical ordering.

  Reply by Sean Nash on 02 February 2023, 08:44
  > Just include HDCommon.h and it will include things like this.

    Reply by Michael Garthwaite on 09 February 2023, 16:31
    > HDcommon.h in a fwcommon file? What about DG? Is it good
    > practice to include a file from a seperate repo?

      Reply by Sean Nash on 09 February 2023, 16:57
      > Fair point.

        Reply by Michael Garthwaite on 09 February 2023, 16:58
        > Fixed. Thanks!

          Reply by wbracken on 09 February 2023, 22:03
          > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Dara Navaei on 09 February 2023, 16:44 
https://devapps.diality.us/cru/DG-DEN-14589-1#c16461

  Remove the blank line.

  Reply by Michael Garthwaite on 09 February 2023, 16:47
  > Fixed. Thanks!

    Reply by Dara Navaei on 09 February 2023, 17:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Dara Navaei on 09 February 2023, 16:44 
https://devapps.diality.us/cru/DG-DEN-14589-1#c16460

  Remove the blank line.

  Reply by Michael Garthwaite on 09 February 2023, 16:47
  > Fixed. Thanks!

    Reply by Dara Navaei on 09 February 2023, 17:06
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-14589-1 https://devapps.diality.us/cru/DG-DEN-14589-1

Title: DG-DEN-14589_Dialin_RTC_Battery_syringe
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (5 active, 1 completed*)
     wbracken   (*)
     Sean Nash
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe