This is a list of all comments for DG-DEN-16093-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 21 August 2023, 13:48 
https://devapps.diality.us/cru/DG-DEN-16093-1#c18659

  Consider calling a (new) function in ConcentratePumps.c that
  would do all of this (decides whether to accept or reject
  command and parks the pumps if accepting, sets reject reason
  code if rejecting).  Function would also create and send the
  cmd response message and return TRUE/FALSE which would set
  local result here for the ack response message below.
  We should reject cmd if pumps are busy/on and/or if current DG
  mode is fill or fault mode.

  Reply by Vinayakam Mani on 21 August 2023, 18:05
  > required changes are done.

    Reply by Sean Nash on 22 August 2023, 10:07
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 22 August 2023, 09:57 
https://devapps.diality.us/cru/DG-DEN-16093-1#c18667

  #includes are sorted.  Put OperationModes.h in its proper
  place.

  Reply by Sean Nash on 22 August 2023, 11:04
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 09:58 
https://devapps.diality.us/cru/DG-DEN-16093-1#c18668

  Add a blank line between declarations and code.

  Reply by Sean Nash on 22 August 2023, 10:56
  > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 25 August 2023, 14:24 
https://devapps.diality.us/cru/DG-DEN-16093-1#c18742

  100% now.

  Reply by Vinayakam Mani on 25 August 2023, 15:03
  > Done.

    Reply by Sean Nash on 28 August 2023, 10:16
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 25 August 2023, 14:25 
https://devapps.diality.us/cru/DG-DEN-16093-1#c18743

  Lets add a comment here that "we are insisting conductivity
  reach 100% of expected level since signal is very noisy and
  peak noise will reach 100% when average is about 93%.   if
  sensor noise is reduced, this level should also be reduced
  accordingly."

  Reply by Vinayakam Mani on 25 August 2023, 15:03
  > Done.

    Reply by Sean Nash on 28 August 2023, 10:16
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-16093-1 https://devapps.diality.us/cru/DG-DEN-16093-1

Title: DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (4 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Darren Cox
     Steve Jarpe