This is a list of all comments for DG-DEN-16280-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ConductivitySensors.c
Revision Comment by Sean Nash on 24 August 2023, 11:25 
https://devapps.diality.us/cru/DG-DEN-16280-1#c18724

  We don't trigger inlet water conductivity alarm in
  post-treatment mode?  Any reason why we're not just saying "==
  MODE_POST"?  What about inlet water pressure/temperature?
  
  FYI - getHDOperationMode() was not working - HD op mode handler
  was mishandling message - fixed in my DENBUG-59 branch, but not
  yet in staging.

  Reply by jtaylor on 24 August 2023, 13:58
  > This was a specific change for this alarm (150), and the
  > associated alarms in this routine.  It appeared there were
  > similar mode limits for temperature as well. Pressure limits
  > were more uniquely related to valve position, I thought. 
  > 
  > I had seen the related changes in 59, and included them in my
  > develop build.

    Reply by Sean Nash on 25 August 2023, 12:42
    > As we discussed, I think alarm 150 and related inlet water
    > alarms are already set to block triggering during rinseback
    > and post-treatment modes.  So these changes are likely not
    > needed.


---

ID: DG-DEN-16280-1 https://devapps.diality.us/cru/DG-DEN-16280-1

Title: DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (6 active, 0 completed*)
     Sean Nash
     Michael Garthwaite
     wbracken
     Dara Navaei
     Darren Cox
     Steve Jarpe