This is a list of all comments for DG-DEN-16680-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeHeatDisinfect.c
Revision Comment by Vinayakam Mani on 28 June 2024, 16:48 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19790

  Will there be any worst-case scenario that the temperature
  never come down (say below 60) and get into a cyclic loop
  between cancel path and cool idle state?

  Reply by Dara Navaei on 01 July 2024, 09:21
  > If it does not come down below 60 and in the cool idle cycle
  > if any issue occurs, the DG Software transitions to the
  > cancel basic path.

  Reply by Vinayakam Mani on 01 July 2024, 09:47
  > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by Sean Nash on 01 July 2024, 17:00 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19801

  This flag is really indicating drain water is not too hot OR we
  are not doing a nocturnal heat disinfect.  Flag name could be
  better.

  Reply by Dara Navaei on 02 July 2024, 08:55
  > Done

    Reply by Sean Nash on 03 July 2024, 12:13
    > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 01 July 2024, 17:05 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19802

  Is this necessary in else?  If so, can move above or below the
  if so you just do it once.

  Reply by Dara Navaei on 02 July 2024, 08:51
  > Removed the one in else.

    Reply by Sean Nash on 03 July 2024, 17:23
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Vinayakam Mani on 28 June 2024, 16:19 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19789

  Looks ALARM_PRIORITY_LOW ranks are in 700 to 800 series range.
  Medium priority rank ranging 400 to 600. Do you want to
  consider this as low priority or medium priority? if medium
  priority rank, can we get rank in to 400 to 600 series?

  Reply by Dara Navaei on 01 July 2024, 09:27
  > Thanks I meant medium priority. Changed the rank to 500.

  Reply by Vinayakam Mani on 01 July 2024, 09:47
  > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by Vinayakam Mani on 28 June 2024, 16:13 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19788

  Do we need "\n" after the " Turn of Inlet water valves."?

  Reply by Dara Navaei on 01 July 2024, 09:20
  > Removed \n

  Reply by Vinayakam Mani on 01 July 2024, 09:48
  > RESOLVED IN CODEWALKTHROUGH.

----------------------------------------
File: DGDefs.h
Revision Comment by Sean Nash on 01 July 2024, 16:52 
https://devapps.diality.us/cru/DG-DEN-16680-1#c19800

  This could just be an event at start.

  Reply by Dara Navaei on 02 July 2024, 09:02
  > Added an event.

    Reply by Sean Nash on 03 July 2024, 09:50
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DEN-16680-1 https://devapps.diality.us/cru/DG-DEN-16680-1

Title: DG-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     jpaguio
     Michael Garthwaite