This is a list of all comments for DG-DEN-9906-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 21 October 2021, 10:52 https://devapps.diality.us/cru/DG-DEN-9906-1#c10887 Update this function header - not RO pump. Reply by hnguyen on 25 October 2021, 10:19 > Fixed Reply by Sean Nash on 27 October 2021, 10:57 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by Sean Nash on 21 October 2021, 10:47 https://devapps.diality.us/cru/DG-DEN-9906-1#c10886 Update function brief - not RO flow. Reply by hnguyen on 25 October 2021, 10:34 > Fixed Reply by Sean Nash on 27 October 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:47 https://devapps.diality.us/cru/DG-DEN-9906-1#c10884 Wrong field name. Reply by hnguyen on 25 October 2021, 10:35 > Fixed Reply by Sean Nash on 27 October 2021, 10:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 25 October 2021, 10:13 https://devapps.diality.us/cru/DG-DEN-9906-1#c10890 This is an input, not an output. Reply by hnguyen on 25 October 2021, 10:55 > Fixed. Reply by Sean Nash on 27 October 2021, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:47 https://devapps.diality.us/cru/DG-DEN-9906-1#c10885 Update return comment. Reply by hnguyen on 25 October 2021, 10:45 > Fixed Reply by Sean Nash on 27 October 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.h Revision Comment by Sean Nash on 21 October 2021, 10:46 https://devapps.diality.us/cru/DG-DEN-9906-1#c10883 Remove "Meter" from function name. Reply by hnguyen on 25 October 2021, 10:29 > Fixed Reply by Sean Nash on 27 October 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskPriority.c Revision Comment by Sean Nash on 21 October 2021, 10:29 https://devapps.diality.us/cru/DG-DEN-9906-1#c10879 Move this up before second pass of FPGA executive call. Reply by hnguyen on 25 October 2021, 10:31 > Fixed Reply by Sean Nash on 27 October 2021, 10:52 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_main.c Revision Comment by Sean Nash on 21 October 2021, 10:54 https://devapps.diality.us/cru/DG-DEN-9906-1#c10888 Move this up with other monitor inits (e.g. initPressures). Reply by hnguyen on 25 October 2021, 10:36 > Fixed Reply by Sean Nash on 27 October 2021, 10:56 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialysateFlow.c Revision Comment by Sean Nash on 21 October 2021, 10:30 https://devapps.diality.us/cru/DG-DEN-9906-1#c10880 Let's average for 1 second (1000 ms) instead of 250 ms. Reply by hnguyen on 25 October 2021, 10:22 > Fixed Reply by Sean Nash on 27 October 2021, 10:54 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:31 https://devapps.diality.us/cru/DG-DEN-9906-1#c10881 I think this is from old flow sensor. Get new value from Dara. Reply by hnguyen on 25 October 2021, 10:21 > Fixed Reply by Sean Nash on 27 October 2021, 10:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 05 November 2021, 09:20 https://devapps.diality.us/cru/DG-DEN-9906-1#c11121 I don't see where this alarm is being triggered. Reply by hnguyen on 10 November 2021, 11:08 > I removed the alarm. Reply by Sean Nash on 10 November 2021, 11:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 27 October 2021, 09:59 https://devapps.diality.us/cru/DG-DEN-9906-1#c10964 These persistent alarms (the enums) are for the FMP. I think we should add new enums for the FMD. Reply by hnguyen on 04 November 2021, 10:38 > Added new alarm ID for dialysate flow out of range. Reply by Dara Navaei on 15 November 2021, 17:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:44 https://devapps.diality.us/cru/DG-DEN-9906-1#c10882 Remove blank line. Reply by hnguyen on 25 October 2021, 10:22 > Blank line removed Reply by Sean Nash on 27 October 2021, 10:54 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 November 2021, 11:13 https://devapps.diality.us/cru/DG-DEN-9906-1#c11297 Need to range check flow. Reply by hnguyen on 15 November 2021, 17:08 > RESOLVED in CODE WALKTHROUGH Reply by Sean Nash on 15 November 2021, 17:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:55 https://devapps.diality.us/cru/DG-DEN-9906-1#c10889 Need "Reset" versions of these override functions too. Also need to add override command message IDs for publish interval and flow override commands + handling of these messages so that these override functions will be called. Reply by hnguyen on 25 October 2021, 10:23 > Added override reset functions Reply by Sean Nash on 27 October 2021, 10:53 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialysateFlow.h Revision Comment by Sean Nash on 21 October 2021, 10:18 https://devapps.diality.us/cru/DG-DEN-9906-1#c10874 Let's find out what the mfgr and p/n are. Reply by hnguyen on 25 October 2021, 10:24 > Fixed Reply by Sean Nash on 27 October 2021, 10:56 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:18 https://devapps.diality.us/cru/DG-DEN-9906-1#c10875 I think we need to lower this minimum. We will be running dialysate at rates as low as 100 mL/min so we probably need to be able to see rates as low as 0.05 L/min. Reply by hnguyen on 25 October 2021, 10:25 > Fixed Reply by Sean Nash on 27 October 2021, 10:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:21 https://devapps.diality.us/cru/DG-DEN-9906-1#c10876 For consistency, we put init functions first. Reply by hnguyen on 25 October 2021, 10:25 > Fixed Reply by Sean Nash on 27 October 2021, 10:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:22 https://devapps.diality.us/cru/DG-DEN-9906-1#c10877 Not sure what this function would do. I don't think we need it. Reply by hnguyen on 25 October 2021, 10:25 > Fixed Reply by Sean Nash on 27 October 2021, 10:54 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2021, 10:22 https://devapps.diality.us/cru/DG-DEN-9906-1#c10878 Need "Reset" versions of these functions as well. And "value" should probably be "ms" to be more specific. Reply by hnguyen on 25 October 2021, 10:26 > Fixed Reply by Sean Nash on 27 October 2021, 10:55 > RESOLVED in CODE WALKTHROUGH. --- ID: DG-DEN-9906-1 https://devapps.diality.us/cru/DG-DEN-9906-1 Title: DG-DEN-9906_HD Dev Flow Measurement Changes Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (1 active, 2 completed*) hnguyen (*) Dara Navaei (*) Behrouz NematiPour