This is a list of all comments for DG-DENBUG-318-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeFill.c
Revision Comment by Sean Nash on 20 May 2025, 10:59 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22041

  max ratio

  Reply by Dara Navaei on 20 May 2025, 13:39
  > Done

    Reply by Sean Nash on 21 May 2025, 08:53
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 29 May 2025, 15:41 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22129

  Should we have before and after values in event data?

  Reply by Dara Navaei on 05 June 2025, 09:20
  > Done.

    Reply by Sean Nash on 05 June 2025, 10:00
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 21 May 2025, 08:55 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22047

  Why are we keeping these in the broadcast?

  Reply by Dara Navaei on 27 May 2025, 09:13
  > Removed. UI is updated too.

    Reply by Sean Nash on 27 May 2025, 09:14
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 20 May 2025, 13:00 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22042

  Should you do something with the received max ratio?  It's
  local, so it's just being dropped.

  Reply by Dara Navaei on 20 May 2025, 13:38
  > Done

    Reply by Sean Nash on 21 May 2025, 09:03
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeGenIdle.c
Revision Comment by Sean Nash on 21 May 2025, 08:59 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22048

  I don't see the flag being set in this function.

  Reply by Dara Navaei on 21 May 2025, 15:28
  > Done

    Reply by Sean Nash on 22 May 2025, 12:54
    > It is an input - don't remove flag there.  It is not an
    > output - so remove it there.

      Reply by Dara Navaei on 22 May 2025, 13:35
      > Done

        Reply by Sean Nash on 27 May 2025, 09:08
        > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 05 June 2025, 10:01 
https://devapps.diality.us/cru/DG-DENBUG-318-1#c22153

  hd mode should be >= standby mode.  You have it backward.

  Reply by Dara Navaei on 05 June 2025, 16:17
  > Done

    Reply by Sean Nash on 05 June 2025, 16:19
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1

Title: DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Vinayakam Mani
     Daniel Ho