This is a list of all comments for DIALIN-DEN-14497-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/blood_leak.py
Revision Comment by Sean Nash on 05 January 2023, 13:16 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15847

  Class should have header.

  Reply by Dara Navaei on 11 January 2023, 11:29
  > We do not have headers for enum classes.

    Reply by Sean Nash on 11 January 2023, 12:56
    > Why not?  Don't we want to say something about it for our
    > Dialin documentation?

      Reply by Dara Navaei on 11 January 2023, 13:25
      > Done

        Reply by Sean Nash on 11 January 2023, 14:01
        > RESOLVED.

Revision Comment by Behrouz NematiPour on 11 January 2023, 16:00 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15968

  why dict() is used instead of simply use {}?

  Reply by Dara Navaei on 19 October 2023, 11:26
  > RESOLVED

Revision Comment by Sean Nash on 05 January 2023, 13:18 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15848

  Gets the most recent embedded mode command response for a given
  command.

  Reply by Dara Navaei on 11 January 2023, 11:26
  > Done

    Reply by Sean Nash on 11 January 2023, 12:56
    > Resolved.

Revision Comment by Behrouz NematiPour on 11 January 2023, 16:03 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15969

  I think we decided to define the return type for at least
  functions that have return values other than None.

  Reply by Dara Navaei on 19 October 2023, 11:26
  > RESOLVED

Revision Comment by Sean Nash on 05 January 2023, 13:20 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15850

  Is this command "embedded"?  Is it redundant with generic
  embedded command function below?  Will it go into f/w embedded
  command queue?

  Reply by Dara Navaei on 11 January 2023, 11:22
  > No this is command schedules the entire zero command sequence
  > while the other embedded mode commands are atomic.

    Reply by Sean Nash on 11 January 2023, 12:55
    > RESOLVED.

Revision Comment by Sean Nash on 05 January 2023, 13:24 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15852

  Should you validate given command before using it to index
  list?

  Reply by Dara Navaei on 11 January 2023, 11:11
  > Done

    Reply by Sean Nash on 11 January 2023, 12:55
    > Done where?

      Reply by Dara Navaei on 11 January 2023, 13:24
      > Done

        Reply by Sean Nash on 11 January 2023, 13:27
        > RESOLVED.

Revision Comment by Sean Nash on 05 January 2023, 13:23 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15851

  Another constraint is that embedded command mode command must
  be given first.
  Should also recommend a minimum time between embedded commands
  constraint to prevent f/w queue from overflowing.

  Reply by Dara Navaei on 11 January 2023, 11:25
  > Done

    Reply by Sean Nash on 11 January 2023, 12:54
    > RESOLVED.

----------------------------------------
File: tests/hd_blood_leak_data.py
Revision Comment by Behrouz NematiPour on 11 January 2023, 16:06 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15970

  what is Z?

  Reply by Dara Navaei on 19 October 2023, 11:27
  > RESOLVED

Revision Comment by Behrouz NematiPour on 11 January 2023, 16:06 
https://devapps.diality.us/cru/DIALIN-DEN-14497-1#c15971

  what is 6?

  Reply by Dara Navaei on 19 October 2023, 12:57
  > RESOLVED


---

ID: DIALIN-DEN-14497-1 https://devapps.diality.us/cru/DIALIN-DEN-14497-1

Title: DIALIN-DEN-14497_DG HD Dev HD DG Dvt Update Part 7
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Behrouz NematiPour   (*)
     Michael Garthwaite