This is a list of all comments for DIALIN-DEN-14589-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/valves.py
Revision Comment by Sean Nash on 30 January 2023, 13:15 
https://devapps.diality.us/cru/DIALIN-DEN-14589-1#c16239

  What happened to reservoir inlet valve?

  Reply by Michael Garthwaite on 30 January 2023, 13:33
  > This is currently in sync with the VALVES_T struct in the DG
  > firmware.
  > 
  > /// Enumeration of valves.
  > typedef enum Valves
  > 
  >     VRF = 0,                                      ///< Valve
  > Reservoir Fill
  >     VRI,                                          ///< Valve
  > Reservoir Inlet
  >     RSRVD_SPACE,                                  ///< This
  > space has been reserved
  >     VRO,                                          ///< Valve
  > Reservoir Outlet
  >     VPO,                                          ///< Valve
  > Pressure Outlet
  >     VBF,                                          ///< Valve
  > Bypass Filter
  >     VRC,                                          ///< Valve
  > Recirculate
  >     VDR,                                          ///< Valve
  > Drain
  >     VPI,                                          ///< Valve
  > Pressure Inlet
  >     VSP,                                          ///< Valve
  > Sampling Port
  >     VRD1,                                         ///< Valve
  > Reservoir 1 Drain
  >     VRD2,                                         ///< Valve
  > Reservoir 2 Drain
  >     VPD,                                          ///< Valve
  > Production Drain
  >     NUM_OF_VALVES                                 ///< Number
  > of valves
  >  VALVES_T;
  > 
  > 
  > [~dnavaei] may be able to clarify as to why

    Reply by Dara Navaei on 30 January 2023, 17:35
    > The reserved space belongs to the former reservoir drain
    > valve that was broken into VRD1 and VRD2.

      Reply by Sean Nash on 31 January 2023, 08:47
      > It does not look aligned with firmware.  
      > firmware has: fill, inlet, reserved, ...
      > you now have fill, reserved, drain, ...

        Reply by Michael Garthwaite on 31 January 2023, 08:50
        > Fixed. Thanks!

          Reply by Sean Nash on 31 January 2023, 08:52
          > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: dialin/common/hd_defs.py
Revision Comment by Sean Nash on 30 January 2023, 13:12 
https://devapps.diality.us/cru/DIALIN-DEN-14589-1#c16238

  I had added button and safety line in another branch.  Why
  removing?

  Reply by Michael Garthwaite on 30 January 2023, 13:29
  > They are currently out of sync with latest staging builds.
  > Kendrick is currently failing his testing using staging
  > builds if he uses enum 18 to get the
  > HD_EVENT_SUB_STATE_CHANGE that was done in
  > http://devapps.diality.us:8060/cru/HD-DEN-14328-1#details
  > 
  > How do you wish to resolve this?

    Reply by Sean Nash on 31 January 2023, 08:48
    > Ok, not sure how this got into staging already.  Will have
    > to add it back later.
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DIALIN-DEN-14589-1 https://devapps.diality.us/cru/DIALIN-DEN-14589-1

Title: DIALIN-DEN-14589_Various_Dialin_fixes
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (5 active, 0 completed*)
     Sean Nash
     Tiffany Mejia
     Dara Navaei
     Behrouz NematiPour
     jishii