This is a list of all comments for DIALIN-DEN-15196-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/events.py
Revision Comment by Sean Nash on 16 May 2023, 15:54 
https://devapps.diality.us/cru/DIALIN-DEN-15196-1#c17611

  Looks like you're mixing old and new state data in the
  dictionary.  
  I would think they would want the new tuples in their own
  dictionary to have a clean, consistent history of state
  transitions.
  What does Sarina and her team think about this?

  Reply by Michael Garthwaite on 16 May 2023, 16:06
  > Can you clarify? Events are organized by event id and by
  > time. Currently the usage is looking like this:
  > 
  > >>> from dialin import HD 
  > >>> hd = HD() 
  > >>> hd.events.get_hd_events(23)
  >  [] 
  > >>> hd.events.get_hd_events(23)
  >  [('1684258483', 3, 1, 255)]
  > >>> hd.events.get_hd_events(23,10)
  >  [('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255),
  > ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255),
  > ('1684258483', 3, 1, 255)
  > >>> from dialin.common.hd_defs import HDEventList 
  > >>>
  > hd.events.get_hd_events(HDEventList.HD_EVENT_OPERATION_STATUS.value,10)
  > 
  > [('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255),
  > ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255),
  > ('1684258483', 3, 1, 255)]
  > 
  > where the user has the option to read the most recent event
  > or a set of the event list.
  > 
  > I'll clarify with V&V. Feedback from john was to change the
  > epoch time to a float.

    Reply by jishii on 16 May 2023, 16:13
    > I'll defer to John he is the one implementing the test code
    > changes.

      Reply by Sean Nash on 16 May 2023, 16:21
      > I think I see how it works - thanks for clarifying.  In
      > your example, '23' is event id for event status (the new
      > state msg), right?
      > RESOLVED.

        Reply by Michael Garthwaite on 16 May 2023, 16:24
        > Correct


---

ID: DIALIN-DEN-15196-1 https://devapps.diality.us/cru/DIALIN-DEN-15196-1

Title: DIALIN-DEN-15196_DIAL_251
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 1 completed*)
     Sean Nash   (*)
     Tiffany Mejia
     Dara Navaei
     Behrouz NematiPour
     jishii