This is a list of all comments for DIALIN-DEN-15196-7.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/OperationModes.h
Revision Comment by Sean Nash on 14 June 2023, 11:15 
https://devapps.diality.us/cru/DIALIN-DEN-15196-7#c17884

  Align comment.

  Reply by Michael Garthwaite on 14 June 2023, 11:21
  > Fixed. Thanks!

    Reply by Sean Nash on 14 June 2023, 11:41
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by Sean Nash on 14 June 2023, 11:17 
https://devapps.diality.us/cru/DIALIN-DEN-15196-7#c17885

  Why does this situation require sending the status event here
  (instead of in op modes where this is usually done)?

  Reply by Michael Garthwaite on 14 June 2023, 11:18
  > We need to display the last Saline event before we switch
  > back.
  > 
  > Due to how we exit this state machine, we call
  > transitionToDialysis() if we go to
  > SALINE_BOLUS_STATE_MAX_DELIVERED which will update the
  > substate back to the current UF state.

    Reply by Sean Nash on 14 June 2023, 11:40
    > RESOLVED in CODE WALKTHROUGH.


---

ID: DIALIN-DEN-15196-7 https://devapps.diality.us/cru/DIALIN-DEN-15196-7

Title: DIAL-262-fixes
Statement of Objectives:
* DIAL-262: fixed operation status event to have more accurate transitioning in between dialysis sub modes.
* DIAL-262: removed old 4th state data when hd pauses in priming
* DIAL-262: added additional event calls for UF and saline transitions.
* DIAL-262: fixes
* Merge branch 'staging' into DEN-15196-DIAL-262-fixes
* DIAL-264: fixed blood prime not showing sub state in operation status event

State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 1 completed*)
     Sean Nash   (*)
     wbracken
     Dara Navaei
     Darren Cox
     jtaylor