This is a list of all comments for DIALIN-DEN-15199-3.

Review Summary: No summary


----------------------------------------
File: dialin/common/test_config_defs.py
Revision Comment by Sean Nash on 02 May 2023, 16:47 
https://devapps.diality.us/cru/DIALIN-DEN-15199-3#c17305

  Let's try not to use words like enable/disable unless we're
  literally doing just that (e.g. disable x alarm).  I think the
  core of this test config is "use wet cartridge".

  Reply by Dara Navaei on 05 May 2023, 12:45
  > Done

    Reply by Sean Nash on 09 May 2023, 08:28
    > RESOLVED.

Revision Comment by Sean Nash on 02 May 2023, 16:47 
https://devapps.diality.us/cru/DIALIN-DEN-15199-3#c17304

  Why commented out and why setting to a DG test config?

  Reply by Dara Navaei on 05 May 2023, 12:45
  > This is to be identical to the enum in firmware but in a
  > Dialin enum we cannot have two enums with one number assigned
  > to them since the Dialin enum is an ordered dictionary so we
  > cannot have multiple keys with one number. I removed the
  > commented enum.

    Reply by Sean Nash on 09 May 2023, 08:36
    > RESOLVED.

----------------------------------------
File: dialin/hd/hd_test_configs.py
Revision Comment by Sean Nash on 02 May 2023, 16:50 
https://devapps.diality.us/cru/DIALIN-DEN-15199-3#c17306

  Why 0xFFFFFFFF?

  Reply by Dara Navaei on 05 May 2023, 12:44
  > This is to very clearly indicate to the user that we are in
  > an unknown state until Dialin receives the status of the test
  > configs from firmware.

    Reply by Sean Nash on 09 May 2023, 10:38
    > RESOLVED.


---

ID: DIALIN-DEN-15199-3 https://devapps.diality.us/cru/DIALIN-DEN-15199-3

Title: DIALIN-DEN-15199_FW DN Sprint 95 Part 2
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     Michael Garthwaite
     Behrouz NematiPour
     jishii