This is a list of all comments for DIALIN-DEN-17093-1. Review Summary: No summary ---------------------------------------- File: dialin/hd/blood_leak.py Revision Comment by Sean Nash on 01 November 2024, 10:32 https://devapps.diality.us/cru/DIALIN-DEN-17093-1#c20720 You have 2 new variables added to publish but I only see one new variable being set in function. Reply by Dara Navaei on 06 November 2024, 09:13 > There two new variables added. Reply by Sean Nash on 06 November 2024, 12:58 > RESOLVED. Revision Comment by Sean Nash on 16 October 2024, 13:26 https://devapps.diality.us/cru/DIALIN-DEN-17093-1#c20483 Average should be a float. ---------------------------------------- File: tests/dg_tests.py Revision Comment by Behrouz NematiPour on 16 October 2024, 14:26 https://devapps.diality.us/cru/DIALIN-DEN-17093-1#c20497 how do we get out of this loop ? Reply by Dara Navaei on 22 October 2024, 09:00 > This is in the dg_tests.py which is used for running various > tests. This is not part of dialin modules. In this case > exiting the loop is done manually by stopping the script. Reply by Behrouz NematiPour on 31 October 2024, 14:13 > I guessed so. > But it is always a good idea of having something to get out > of the loop. > But needs a bigger discussion. > > RESOLVED. --- ID: DIALIN-DEN-17093-1 https://devapps.diality.us/cru/DIALIN-DEN-17093-1 Title: DIALIN-DEN-17093_Blood Leak Zeroing IN Treatment Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (3 active, 3 completed*) Sean Nash (*) Vinayakam Mani (*) Behrouz NematiPour (*) Tiffany Mejia jpaguio Michael Garthwaite