This is a list of all comments for DIALIN-DEN-3593-1. Review Summary: No summary ---------------------------------------- File: setup.py Revision Comment by pmontazemi on 18 July 2020, 22:12 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2764 Remove extra line. Reply by plucia on 20 July 2020, 09:42 > Done Reply by pmontazemi on 20 July 2020, 10:04 > RESOLVED. ---------------------------------------- File: dialin/hd/alarms.py Revision Comment by pmontazemi on 18 July 2020, 21:59 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2748 Remove commented line. Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:04 > RESOLVED. ---------------------------------------- File: dialin/hd/hemodialysis_device.py Revision Comment by pmontazemi on 18 July 2020, 22:05 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2749 Remove extra line(s). Reply by plucia on 20 July 2020, 09:45 > Done Reply by pmontazemi on 20 July 2020, 10:05 > RESOLVED. ---------------------------------------- File: dialin/hd/pressure_occlusion.py Revision Comment by pmontazemi on 18 July 2020, 22:06 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2750 HD stands for Hemodialysis Delivery, not Device. Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:05 > RESOLVED. Revision Comment by pmontazemi on 18 July 2020, 22:06 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2751 Remove extra line. Reply by plucia on 20 July 2020, 09:46 > Done Reply by pmontazemi on 20 July 2020, 10:05 > RESOLVED. ---------------------------------------- File: dialin/hd/rtc.py Revision Comment by pmontazemi on 18 July 2020, 22:06 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2752 HD stands for Hemodialysis Delivery, not Device. Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:05 > RESOLVED. ---------------------------------------- File: dialin/hd/treatment.py Revision Comment by pmontazemi on 18 July 2020, 22:07 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2753 HD stands for Hemodialysis Delivery, not Device. Reply by plucia on 20 July 2020, 09:46 > Done Reply by pmontazemi on 20 July 2020, 10:06 > RESOLVED. ---------------------------------------- File: dialin/hd/ui_proxy.py Revision Comment by pmontazemi on 18 July 2020, 22:07 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2754 HD stands for Hemodialysis Delivery, not Device. Reply by plucia on 20 July 2020, 09:46 > Done Reply by pmontazemi on 20 July 2020, 10:06 > RESOLVED. ---------------------------------------- File: dialin/hd/watchdog.py Revision Comment by pmontazemi on 18 July 2020, 22:08 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2755 HD stands for Hemodialysis Delivery, not Device. Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:06 > RESOLVED. ---------------------------------------- File: dialin/dg/dialysate_generator.py Revision Comment by Sean Nash on 07 July 2020, 08:32 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2705 Why is there two dialysate_generator.py files in this review project? Reply by plucia on 16 July 2020, 16:35 > I'm not sure, it seems like it could be an issue with Fisheye > / Crucible? There is only one file on the branch: > http://dvm-linux02:7990/projects/VV/repos/dialin/browse/dialin/dg?at=refs%2Fheads%2FDEN-3593-Maintenance Reply by Sean Nash on 16 July 2020, 16:59 > RESOLVED. ---------------------------------------- File: docs/source/index.rst Revision Comment by pmontazemi on 18 July 2020, 22:11 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2761 Copyright header missing. Reply by plucia on 20 July 2020, 09:48 > Done Reply by pmontazemi on 20 July 2020, 10:07 > RESOLVED. ---------------------------------------- File: tests/test_demo.py Revision Comment by pmontazemi on 18 July 2020, 22:12 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2762 Why 2 line spacings in test files when lib/API files have only 2 line spacing? Reply by plucia on 20 July 2020, 09:34 > PEP8 E302: Two blank lines are expected between functions and > classes. > PEP8 E303: Two blank lines are expected between functions and > classes and one blank line is expected between methods of a > class. Reply by pmontazemi on 20 July 2020, 10:08 > RESOLVED. ---------------------------------------- File: docs/source/conf.py Revision Comment by pmontazemi on 18 July 2020, 22:10 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2759 Copyright header missing. Reply by plucia on 20 July 2020, 09:43 > Done Reply by pmontazemi on 20 July 2020, 10:07 > RESOLVED. Revision Comment by pmontazemi on 18 July 2020, 22:10 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2758 Diality Inc (not Inc.) Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:07 > RESOLVED. Revision Comment by pmontazemi on 18 July 2020, 22:11 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2760 Remove extra lines. Reply by plucia on 20 July 2020, 09:45 > Done Reply by pmontazemi on 20 July 2020, 10:07 > RESOLVED. ---------------------------------------- File: version.py Revision Comment by pmontazemi on 18 July 2020, 22:13 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2765 Copyright header missing. Reply by plucia on 20 July 2020, 09:42 > DONE Reply by pmontazemi on 20 July 2020, 10:09 > Comment says DONE but I still cannot see the copyright > header. Reply by plucia on 20 July 2020, 10:19 > This file is symbolically linked to dialin/version.py - > the copyright header is in that file Reply by pmontazemi on 20 July 2020, 11:13 > RESOLVED. ---------------------------------------- File: dialin/utils/base.py Revision Comment by pmontazemi on 18 July 2020, 22:09 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2756 Copyright header missing. Reply by plucia on 20 July 2020, 09:54 > Done Reply by pmontazemi on 20 July 2020, 10:06 > RESOLVED. Revision Comment by pmontazemi on 18 July 2020, 22:09 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2757 Remove extra line. Reply by plucia on 20 July 2020, 09:44 > Done Reply by pmontazemi on 20 July 2020, 10:07 > RESOLVED. ---------------------------------------- File: README.md Revision Comment by pmontazemi on 18 July 2020, 22:12 https://devapps.diality.us/cru/DIALIN-DEN-3593-1#c2763 Copyright header missing. Reply by plucia on 20 July 2020, 09:43 > Done Reply by pmontazemi on 20 July 2020, 10:08 > RESOLVED. --- ID: DIALIN-DEN-3593-1 https://devapps.diality.us/cru/DIALIN-DEN-3593-1 Title: DIALIN-DEN-3593_Maintenance Statement of Objectives: State: Closed Summary: Author: plucia Moderator: plucia Reviewers: (0 active, 2 completed*) Sean Nash (*) pmontazemi (*)