This is a list of all comments for DIALIN-DEN-3875-1.

Review Summary: No summary


----------------------------------------
File: dialin/squish/denaliMessages.py
Revision Comment by plucia on 14 August 2020, 13:52 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3441

  The epytext docstrings skeleton should stay and we should add
  to it so the code is well-documented

  Reply by Behrouz NematiPour on 28 August 2020, 11:38
  > Hey Peter,
  > You're right I removed them to easier do the merge.
  > Since the task DEN-4690: Doxygenization has been changed to
  > story and there is a code review sub-task for that, let's
  > address all the documentation in that stoy.

    Reply by plucia on 28 August 2020, 14:02
    > RESOLVED

Revision Comment by plucia on 25 August 2020, 11:29 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3884

  These need to be filled in so the API documentation is
  populated

  Reply by Behrouz NematiPour on 28 August 2020, 11:47
  > Hey Peter,
  > You're right I removed them to easier do the merge.
  > Since the task DEN-4690: Doxygenization has been changed to
  > story and there is a code review sub-task for that, let's
  > address all the documentation in that stoy.

    Reply by plucia on 28 August 2020, 14:02
    > RESOLVED

Revision Comment by plucia on 25 August 2020, 11:29 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3885

  These need to be filled in so the API documentation is
  populated

  Reply by Behrouz NematiPour on 28 August 2020, 11:47
  > Hey Peter,
  > You're right I removed them to easier do the merge.
  > Since the task DEN-4690: Doxygenization has been changed to
  > story and there is a code review sub-task for that, let's
  > address all the documentation in that stoy.

    Reply by plucia on 28 August 2020, 14:02
    > RESOLVED

Revision Comment by plucia on 25 August 2020, 11:29 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3886

  These need to be filled in so the API documentation is
  populated

  Reply by Behrouz NematiPour on 28 August 2020, 11:47
  > Hey Peter,
  > You're right I removed them to easier do the merge.
  > Since the task DEN-4690: Doxygenization has been changed to
  > story and there is a code review sub-task for that, let's
  > address all the documentation in that stoy.

    Reply by plucia on 28 August 2020, 14:02
    > RESOLVED

Revision Comment by plucia on 25 August 2020, 11:29 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3887

  These need to be filled in so the API documentation is
  populated, same for the rest of the functions below

  Reply by Behrouz NematiPour on 28 August 2020, 11:48
  > Hey Peter,
  > You're right I removed them to easier do the merge.
  > Since the task DEN-4690: Doxygenization has been changed to
  > story and there is a code review sub-task for that, let's
  > address all the documentation in that stoy.

    Reply by plucia on 28 August 2020, 14:02
    > RESOLVED

----------------------------------------
File: dialin/squish/messageBuilder.py
Revision Comment by pmontazemi on 12 August 2020, 14:59 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3323

  Remove extra line.

  Reply by Behrouz NematiPour on 28 August 2020, 15:05
  > Removed in the latest code review which is the Saline Bolus.
  > You'll also have it in Doxygenization.

    Reply by pmontazemi on 28 August 2020, 16:44
    > RESOLVED.

Revision Comment by pmontazemi on 12 August 2020, 14:59 
https://devapps.diality.us/cru/DIALIN-DEN-3875-1#c3324

  Remove extra line.

  Reply by Behrouz NematiPour on 28 August 2020, 15:05
  > Removed in the latest code review which is the Saline Bolus.
  > You'll also have it in Doxygenization.

    Reply by pmontazemi on 28 August 2020, 16:44
    > RESOLVED.


---

ID: DIALIN-DEN-3875-1 https://devapps.diality.us/cru/DIALIN-DEN-3875-1

Title: DIALIN-DEN-3875_Logging_2of3
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)