This is a list of all comments for DIALIN-DEN-3964-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/valves.py
Revision Comment by pmontazemi on 18 July 2020, 22:19 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2772

  Remove extra line.

  Reply by plucia on 20 July 2020, 10:27
  > Done

    Reply by pmontazemi on 20 July 2020, 11:16
    > RESOLVED.

Revision Comment by pmontazemi on 18 July 2020, 22:20 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2773

  Weird that this code change was also part of the other code
  review. Please check.

  Reply by plucia on 20 July 2020, 10:08
  > Are you sure they were the same changes? In the other review,
  > the change was to fix the bit masking:
  > http://dvm-linux02:8060/cru/DIALIN-DEN-3593-1#CFR-14160
  > In this review, the change is to upgrade the valve state
  > handler to write valve states to the "state" key / value pair
  > instead of the valve state variable itself.

    Reply by pmontazemi on 20 July 2020, 11:14
    > RESOLVED.

----------------------------------------
File: tests/unit_tests.py
Revision Comment by pmontazemi on 18 July 2020, 22:25 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2780

  Remove extra line.

  Reply by plucia on 20 July 2020, 10:16
  > PEP8 requires that there are two spaces between functions
  > outside of a class. 
  > If I delete a space, it violates PEP8: E305

    Reply by pmontazemi on 20 July 2020, 11:16
    > RESOLVED.

----------------------------------------
File: dialin/squish/__init__.py
Revision Comment by pmontazemi on 18 July 2020, 22:23 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2777

  Copyright header is missing.

  Reply by plucia on 20 July 2020, 10:26
  > Done

    Reply by pmontazemi on 20 July 2020, 11:15
    > RESOLVED.

----------------------------------------
File: tests/test_imports.py
Revision Comment by pmontazemi on 18 July 2020, 22:25 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2779

  Remove extra lines.

  Reply by plucia on 20 July 2020, 10:31
  > Done

    Reply by pmontazemi on 20 July 2020, 11:16
    > RESOLVED.

----------------------------------------
File: tools/install_to_venv.sh
Revision Comment by pmontazemi on 18 July 2020, 22:26 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2781

  Copyright header missing.

  Reply by plucia on 20 July 2020, 10:31
  > Done

    Reply by pmontazemi on 20 July 2020, 11:16
    > RESOLVED.

----------------------------------------
File: dialin/dg/__init__.py
Revision Comment by pmontazemi on 18 July 2020, 22:16 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2770

  Copyright header missing.

  Reply by plucia on 20 July 2020, 10:26
  > Done

    Reply by pmontazemi on 20 July 2020, 11:13
    > RESOLVED.

----------------------------------------
File: dialin/dg/dialysate_generator.py
Revision Comment by pmontazemi on 18 July 2020, 22:17 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2771

  If comments end all with ".", we should be consistent, my
  preference would be to have no "." at the end of each comment

  Reply by plucia on 20 July 2020, 10:26
  > Done

    Reply by pmontazemi on 20 July 2020, 11:14
    > RESOLVED.

----------------------------------------
File: dialin/hd/hemodialysis_device.py
Revision Comment by pmontazemi on 18 July 2020, 22:22 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2775

  Remove extra line.

  Reply by plucia on 20 July 2020, 10:26
  > Done

    Reply by pmontazemi on 20 July 2020, 11:15
    > RESOLVED.

----------------------------------------
File: dialin/utils/base.py
Revision Comment by pmontazemi on 18 July 2020, 22:24 
https://devapps.diality.us/cru/DIALIN-DEN-3964-1#c2778

  Remove extra line.

  Reply by plucia on 20 July 2020, 10:26
  > Done

    Reply by pmontazemi on 20 July 2020, 11:16
    > RESOLVED.


---

ID: DIALIN-DEN-3964-1 https://devapps.diality.us/cru/DIALIN-DEN-3964-1

Title: DIALIN-DEN-3964_Maintenance
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)
     Behrouz NematiPour