This is a list of all comments for DIALIN-DEN-4211-1. Review Summary: No summary ---------------------------------------- File: dialin/hd/ui_proxy.py Revision Comment by pmontazemi on 28 August 2020, 08:49 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4077 Why volumes are initialized to 0 (int) in some cases and to 0.0 (float) in other cases? Reply by Sean Nash on 28 August 2020, 09:53 > Most of these treatment parameters are integers, but a few > are floating point due to the small range and/or fine > resolution (e.g. Heparin dispense rate has a range of 0 to > 1.0 mL/hr.) Reply by pmontazemi on 28 August 2020, 16:57 > RESOLVED. ---------------------------------------- File: dialin/squish/crc.py Revision Comment by pmontazemi on 28 August 2020, 08:50 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4079 Where did the copyright header go? Reply by Dara Navaei on 08 September 2020, 10:59 > This is an old formatted copyright. The new copyright format > will be inserted into the file automatically by Bamboo. Reply by pmontazemi on 09 September 2020, 14:50 > RESOLVED. ---------------------------------------- File: dialin/squish/denaliMessages.py Revision Comment by pmontazemi on 28 August 2020, 08:51 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4080 Where did the copyright header go? Reply by Dara Navaei on 08 September 2020, 10:59 > This is an old formatted copyright. The new copyright format > will be inserted into the file automatically by Bamboo. Reply by pmontazemi on 09 September 2020, 14:49 > RESOLVED. ---------------------------------------- File: dialin/squish/globals.py Revision Comment by pmontazemi on 28 August 2020, 08:53 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4081 Where id the copyright header go? Reply by Dara Navaei on 08 September 2020, 10:59 > This is an old formatted copyright. The new copyright format > will be inserted into the file automatically by Bamboo. Reply by pmontazemi on 09 September 2020, 14:49 > RESOLVED. ---------------------------------------- File: dialin/squish/messageBuilder.py Revision Comment by pmontazemi on 28 August 2020, 08:53 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4082 Where did the copyright header go? Reply by Dara Navaei on 08 September 2020, 10:59 > This is an old formatted copyright. The new copyright format > will be inserted into the file automatically by Bamboo. Reply by pmontazemi on 09 September 2020, 14:49 > RESOLVED. Revision Comment by pmontazemi on 28 August 2020, 08:54 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4083 Remove extra line. Reply by Sean Nash on 28 August 2020, 09:52 > Done Reply by pmontazemi on 28 August 2020, 16:56 > RESOLVED. ---------------------------------------- File: dialin/squish/unittests.py Revision Comment by pmontazemi on 28 August 2020, 08:54 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4084 Where did the copyright header go? Reply by Dara Navaei on 08 September 2020, 10:59 > This is an old formatted copyright. The new copyright format > will be inserted into the file automatically by Bamboo. Reply by pmontazemi on 09 September 2020, 14:49 > RESOLVED. ---------------------------------------- File: dialin/squish/utils.py Revision Comment by pmontazemi on 28 August 2020, 08:54 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4085 Where did the copyright header go? Reply by Sean Nash on 28 August 2020, 09:47 > It's not clear to me how all of this squish content came into > this branch or why any of it is changed. I'll discuss with > Peter and see what happened and what state is should be in. > May be dealt with when merging this branch to staging. Reply by Dara Navaei on 08 September 2020, 10:55 > This is an old formatted copyright. The new copyright > format will be inserted into the file automatically by > Bamboo. Reply by pmontazemi on 09 September 2020, 14:49 > RESOLVED. ---------------------------------------- File: dialin/dg/accelerometer.py Revision Comment by plucia on 27 August 2020, 12:45 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4056 The logger should be passed to the constructor so a script writer can turn the logger and any debug messages on or off Reply by Sean Nash on 27 August 2020, 17:32 > Waiting until merge to staging - logger not yet available > until then. Reply by plucia on 01 September 2020, 14:39 > RESOLVED. Revision Comment by pmontazemi on 28 August 2020, 08:31 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4072 All one liners. Reply by Sean Nash on 28 August 2020, 09:58 > Done Reply by pmontazemi on 08 September 2020, 10:00 > RESOLVED. Revision Comment by plucia on 27 August 2020, 12:46 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4057 To allow toggling of print statements, replace prints with self.logger.debug("..."), self.logger.info("..."), self.logger.error("..."), etc.. Reply by Sean Nash on 27 August 2020, 16:58 > Waiting until merge to staging - logger not yet available > until then. Reply by plucia on 01 September 2020, 14:39 > RESOLVED ---------------------------------------- File: dialin/hd/accelerometer.py Revision Comment by plucia on 09 September 2020, 10:36 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4570 For the new code, when you do the merge make sure that the message ID's are added to common/msg_defs.py instead of distributed to each class. I have an existing ticket [http://dvm-linux02:8080/browse/DIAL-33] to read the message IDs and alarm IDs from common for older code. Reply by Sean Nash on 09 September 2020, 12:29 > I don't see a common folder in this branch. Will have to do > after merge to staging branch? Reply by plucia on 09 September 2020, 12:47 > Yes Reply by Dara Navaei on 19 October 2023, 13:17 > RESOLVED Revision Comment by plucia on 27 August 2020, 12:42 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4054 The logger should be passed to the constructor so a script writer can turn the logger and any debug messages on or off Reply by Sean Nash on 27 August 2020, 17:32 > Waiting until merge to staging - logger not yet available > until then. Reply by plucia on 01 September 2020, 14:39 > RESOLVED. Revision Comment by plucia on 27 August 2020, 12:43 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4055 To allow toggling of print statements, replace prints with self.logger.debug("..."), self.logger.info("..."), self.logger.error("..."), etc.. Reply by Sean Nash on 27 August 2020, 17:32 > Waiting until merge to staging - logger not yet available > until then. Reply by plucia on 01 September 2020, 14:39 > RESOLVED. ---------------------------------------- File: dialin/dg/dialysate_generator.py Revision Comment by pmontazemi on 28 August 2020, 08:32 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4073 One liner Reply by Sean Nash on 08 September 2020, 09:33 > Done Reply by pmontazemi on 08 September 2020, 10:00 > RESOLVED. Revision Comment by pmontazemi on 28 August 2020, 08:33 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4074 All one liners Reply by Sean Nash on 28 August 2020, 09:55 > Done. Reply by pmontazemi on 08 September 2020, 10:00 > RESOLVED. ---------------------------------------- File: dialin/dg/heaters.py Revision Comment by pmontazemi on 28 August 2020, 08:35 https://devapps.diality.us/cru/DIALIN-DEN-4211-1#c4075 Remove extra lines. Reply by Sean Nash on 08 September 2020, 09:31 > Done Reply by pmontazemi on 08 September 2020, 09:59 > RESOLVED. --- ID: DIALIN-DEN-4211-1 https://devapps.diality.us/cru/DIALIN-DEN-4211-1 Title: DIALIN-DEN-4211_HD Treatment Parameters Mode Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)