This is a list of all comments for DIALIN-DEN-4640-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by pmontazemi on 05 October 2020, 15:17 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5200

  Realign everything

  Reply by pmontazemi on 06 October 2020, 09:38
  > RESOLVED.

----------------------------------------
File: dialin/hd/alarms.py
Revision Comment by pmontazemi on 05 October 2020, 15:21 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5202

  Where were these HD Alarms moved to?

  Reply by Sean Nash on 05 October 2020, 16:03
  > common/alarm_defs.py

    Reply by pmontazemi on 06 October 2020, 09:39
    > RESOLVED.

----------------------------------------
File: dialin/hd/dialysate_inlet_flow.py
Revision Comment by plucia on 30 October 2020, 09:47 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5780

  This extra comma will cause an issue with the publish decorator

  Reply by Sean Nash on 30 October 2020, 10:27
  > Fixed.

    Reply by plucia on 30 October 2020, 10:30
    > RESOLVED

----------------------------------------
File: dialin/hd/dialysate_outlet_flow.py
Revision Comment by pmontazemi on 04 November 2020, 09:13 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5915

  Why the HD was removed? It looked like this is an HD message
  and leaving HD in the msg ID could add more meaning?

  Reply by Sean Nash on 09 November 2020, 10:02
  > HD is still part of the msg name.  Peter had me move all of
  > these msg ID definitions to a common enum (moved from "self"
  > to common MsgIDs enum).

    Reply by pmontazemi on 09 November 2020, 10:26
    > RESOLVED.

----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by pmontazemi on 05 October 2020, 15:24 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5203

  message aligned under struct

  Reply by Sean Nash on 05 October 2020, 16:02
  > Done.

    Reply by pmontazemi on 06 October 2020, 09:38
    > RESOLVED.

Revision Comment by plucia on 06 October 2020, 10:11 
https://devapps.diality.us/cru/DIALIN-DEN-4640-1#c5262

  Just curious, what was the reason for the deletion?

  Reply by Sean Nash on 06 October 2020, 11:11
  > I think it was a little out of date with UF change messaging.
  > Obsolete.

    Reply by plucia on 06 October 2020, 11:14
    > Okay, thanks. RESOLVED.


---

ID: DIALIN-DEN-4640-1 https://devapps.diality.us/cru/DIALIN-DEN-4640-1

Title: DIALIN-DEN-4640_Saline Bolus
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)