This is a list of all comments for DIALIN-DEN-6631-1.

Review Summary: No summary


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by pmontazemi on 15 February 2021, 13:09 
https://devapps.diality.us/cru/DIALIN-DEN-6631-1#c8111

  Remove extra lines.

  Reply by Behrouz NematiPour on 15 February 2021, 18:08
  > there has to be two empty lines.
  > removed 1 of 3 lines.

    Reply by pmontazemi on 16 February 2021, 13:06
    > RESOLVED.

----------------------------------------
File: dialin/protocols/CAN.py
Revision Comment by plucia on 15 February 2021, 13:24 
https://devapps.diality.us/cru/DIALIN-DEN-6631-1#c8115

  Print statements have been replaced with self.logger calls in
  dialin to prevent flooding users consoles. So, it'd be best to
  either remove this or use self.logger.debug(...) instead

  Reply by Behrouz NematiPour on 15 February 2021, 14:08
  > It would be great if we could make it optional.
  > For the testing, it is very useful.
  > I'll remove it but later, would like to have it as an option
  > that can be set available manually.

    Reply by Behrouz NematiPour on 15 February 2021, 18:02
    > Made it optional and disabled by default and only in
    > Simulator is enabled.

      Reply by plucia on 16 February 2021, 13:25
      > RESOLVED


---

ID: DIALIN-DEN-6631-1 https://devapps.diality.us/cru/DIALIN-DEN-6631-1

Title: DIALIN-DEN-6631_UI DEV POST Treatment Rinseback
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)