This is a list of all comments for DIALIN-DEN-9626-1.

Review Summary: No summary


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by Sean Nash on 21 September 2021, 14:46 
https://devapps.diality.us/cru/DIALIN-DEN-9626-1#c10848

  Why some commands return boolean and some none?  And this
  function always returns TRUE so what is the point?
  Also, when a function returns something, I thought we decided
  to show that in the declaration ( e.g. foo() -> int: )

  Reply by Behrouz NematiPour on 21 September 2021, 16:28
  > Good point,
  > I could not find this function in the simulator, and it means
  > it is a very old function implemented when we were doing
  > Automated Unit Tests.
  > The return value may have been used in the Unit test since
  > this is the message (create treatment parameters response)
  > which has bool for each param and the return could be the
  > final result (and of all single ones).
  > I agree we decided but since this code has not been touched
  > since then and that decision has been made after that
  > function it doesn't have that in the definition.
  > I would rather not touch it, since it wasn't part of this
  > task modification (Safety Volume) and I don't know what will
  > break after the modification.

    Reply by Sean Nash on 21 September 2021, 18:28
    > RESOLVED.


---

ID: DIALIN-DEN-9626-1 https://devapps.diality.us/cru/DIALIN-DEN-9626-1

Title: DIALIN-DEN-9626_DEV Bluetooth Cuff Integration
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)