This is a list of all comments for DIALIN-REFACTORING-3-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/buttons.py
Revision Comment by pmontazemi on 28 April 2020, 22:24 
https://devapps.diality.us/cru/DIALIN-REFACTORING-3-1#c1717

  Add copyright header to all files.

  Reply by plucia on 29 April 2020, 10:29
  > Done.

    Reply by pmontazemi on 30 April 2020, 08:14
    > RESOLVED.

----------------------------------------
File: setup.py
Revision Comment by pmontazemi on 28 April 2020, 22:28 
https://devapps.diality.us/cru/DIALIN-REFACTORING-3-1#c1718

  I thought we were using Python v3.6.8 on Linux Ubuntu v18.04.3
  LTS (64-bit) running in Oracle VirtualBox v5.2.32 (64-bit) on
  Windows Pro 10 (64-bit) OS?

  Reply by plucia on 29 April 2020, 09:14
  > The purpose of programming language specification here is
  > description only and there are no pypi classifiers that
  > specify the python version beyond MAJOR.MINOR. 
  > 
  > Since python-can has an issue working on windows, I haven't
  > specified windows as a supported version.
  > 
  > I checked, and there is no pypi classifier for Virtualbox, or
  > any other type of virtualization platform. This makes sense
  > because specifying a python package as being compatible with
  > a virtualization environment is out of the scope of the
  > setuptools configuration. 
  > 
  > There are also no pypi specifiers for Ubuntu specifically.
  > So, the classifier I could find that best matches the OS
  > we're running is Linux.

    Reply by pmontazemi on 29 April 2020, 09:58
    > RESOLVED.

----------------------------------------
File: tools/setup_virtual_can.sh
Revision Comment by Behrouz NematiPour on 04 May 2020, 12:05 
https://devapps.diality.us/cru/DIALIN-REFACTORING-3-1#c1727

  Why we setup to virtual can 0,1 ?

  Reply by Behrouz NematiPour on 04 May 2020, 12:16
  > talked with Peter and it's OK.
  > RESOLVED.


---

ID: DIALIN-REFACTORING-3-1 https://devapps.diality.us/cru/DIALIN-REFACTORING-3-1

Title: DIALIN_Refactoring 3
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 2 completed*)
     Behrouz NematiPour   (*)
     pmontazemi   (*)