This is a list of all comments for DIALIN-UI-S63-1.

Review Summary: No summary


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by Michael Garthwaite on 08 February 2022, 16:29 
https://devapps.diality.us/cru/DIALIN-UI-S63-1#c11868

  These are all the same changes from
  
  http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

  Reply by Behrouz NematiPour on 14 February 2022, 12:33
  > It could be since both of the code reviews are for the S63
  > changes.
  > Probably the same commit has been added.

    Reply by Michael Garthwaite on 15 February 2022, 11:10
    > RESOVLED

      Reply by Dara Navaei on 19 October 2023, 13:09
      > RESOLVED

Revision Comment by Sean Nash on 08 February 2022, 08:27 
https://devapps.diality.us/cru/DIALIN-UI-S63-1#c11861

  Header suggests there are only 2 parameters.  What is this 3rd
  param and why is it zero?

  Reply by Behrouz NematiPour on 14 February 2022, 14:32
  > You are right, 
  > It is just a temporary fix to make the API work with the
  > current UI which is not updated to the latest Messages list,
  > for the LTTS to get them unblocked.
  > As part of the LTTS support and the messages list update/sync
  > it will be removed/fixed.

    Reply by Sean Nash on 15 February 2022, 10:18
    > RESOLVED.

----------------------------------------
File: dialin/utils/conversions.py
Revision Comment by Michael Garthwaite on 08 February 2022, 16:27 
https://devapps.diality.us/cru/DIALIN-UI-S63-1#c11867

  These are all the same changes from 
  
  http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

  Reply by Behrouz NematiPour on 14 February 2022, 12:36
  > Thanks for your attention to the details.
  > I think you are right.
  > Probably the code review is duplicate, my bad.

    Reply by Michael Garthwaite on 15 February 2022, 11:11
    > RESOLVED

Revision Comment by Sean Nash on 08 February 2022, 08:34 
https://devapps.diality.us/cru/DIALIN-UI-S63-1#c11862

  This looks backwards.  double should be 8, float should be 4.

  Reply by Behrouz NematiPour on 14 February 2022, 14:31
  > Great catch,
  > Thanks, fixed.
  > Fortunately, it wasn't being used anywhere.

    Reply by Sean Nash on 15 February 2022, 10:17
    > RESOLVED.


---

ID: DIALIN-UI-S63-1 https://devapps.diality.us/cru/DIALIN-UI-S63-1

Title: DIALIN-UI-S63
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 3 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei   (*)