This is a list of all comments for HD-DEN-10153-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeTreatmentParams.c
Revision Comment by Sean Nash on 26 October 2021, 13:31 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10924

  Move this up into accepted condition above.  Also, we don't
  need a public function to set original value since variable is
  local to this module.

  Reply by Behrouz NematiPour on 26 October 2021, 14:08
  > Fixed

    Reply by Sean Nash on 27 October 2021, 11:00
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:31 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10925

  Don't need this function - variable is local to this module.

  Reply by Behrouz NematiPour on 26 October 2021, 14:02
  > Fixed

    Reply by Sean Nash on 27 October 2021, 11:00
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:32 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10926

  Don't put types here.  Also, this function has no outputs.
  Input is origTreatmentParams.uFVolume_L.

  Reply by Behrouz NematiPour on 26 October 2021, 14:08
  > Fixed

    Reply by Sean Nash on 27 October 2021, 10:59
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:41 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10928

  If no params, put void.

  Reply by Behrouz NematiPour on 26 October 2021, 14:08
  > Fixed

    Reply by Sean Nash on 27 October 2021, 10:59
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:41 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10929

  If no params, put void.

  Reply by Behrouz NematiPour on 26 October 2021, 14:08
  > Fixed

    Reply by Sean Nash on 27 October 2021, 10:59
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatmentParams.h
Revision Comment by Sean Nash on 26 October 2021, 13:18 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10921

  Add space before and after params (see others above).

  Reply by Behrouz NematiPour on 26 October 2021, 14:09
  > Fixed

    Reply by Sean Nash on 27 October 2021, 11:01
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:18 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10922

  If no params, use void (see SignalUserCancelTreatment above).

  Reply by Behrouz NematiPour on 26 October 2021, 14:09
  > Fixed

    Reply by Sean Nash on 27 October 2021, 11:00
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 26 October 2021, 13:17 
https://devapps.diality.us/cru/HD-DEN-10153-1#c10920

  Why the extra blank line?

  Reply by Behrouz NematiPour on 26 October 2021, 14:09
  > Fixed

    Reply by Sean Nash on 27 October 2021, 11:01
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-10153-1 https://devapps.diality.us/cru/HD-DEN-10153-1

Title: HD-DEN-10153_Treatment Log Prescribed UF
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     hnguyen   (*)
     Dara Navaei