This is a list of all comments for HD-DEN-11250-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/SyringePump.c Revision Comment by Sean Nash on 28 January 2022, 13:26 https://devapps.diality.us/cru/HD-DEN-11250-1#c11783 These min/max bolus rates are obsolete now, right? Reply by hnguyen on 31 January 2022, 13:49 > Yes, we use fixed rate. Removed min/max bolus rates Reply by Sean Nash on 01 February 2022, 13:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 09:38 https://devapps.diality.us/cru/HD-DEN-11250-1#c11786 Max bolus rate is obsolete as it is now fixed. Reply by hnguyen on 31 January 2022, 13:50 > Done. Removed max bolus rate. Reply by Sean Nash on 01 February 2022, 13:26 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 09:38 https://devapps.diality.us/cru/HD-DEN-11250-1#c11787 Bolus time obsolete. Reply by hnguyen on 31 January 2022, 13:51 > Done. Removed bolus time HEPARIN_BOLUS_TIME_HR. > Also removed bolus time HEPARIN_BOLUS_TIME_HR in function > handleSyringePumpSeekState() > F32 hepDurHr = ( (F32)( setTxDur - preStop ) / > (F32)MIN_PER_HOUR ) - HEPARIN_BOLUS_TIME_HR; Reply by Sean Nash on 01 February 2022, 13:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 January 2022, 13:26 https://devapps.diality.us/cru/HD-DEN-11250-1#c11784 This name and comment suggest that threshold is absolute (literally > 0.5V), but threshold is actually a baseline voltage (taken after seek) + 0.5V. Reply by hnguyen on 31 January 2022, 15:15 > Renamed SYRINGE_FORCE_OCCLUSION_THRESHOLD_VOLT to > SYRINGE_FORCE_OCCLUSION_DIFF_V Reply by Sean Nash on 01 February 2022, 13:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 February 2022, 10:23 https://devapps.diality.us/cru/HD-DEN-11250-1#c11885 Make a #define for bolus rate (40.0) and use here to initialize. Also initialize ovData field to the same #define. Reply by Dara Navaei on 19 October 2023, 07:55 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 28 January 2022, 13:28 https://devapps.diality.us/cru/HD-DEN-11250-1#c11785 I think we should say end of seek or before prime instead of start of priming. Reply by hnguyen on 31 January 2022, 13:58 > Renamed forceAtStartOfPriming to forceAtEndOfSeek. Reply by Sean Nash on 01 February 2022, 13:26 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 09:39 https://devapps.diality.us/cru/HD-DEN-11250-1#c11788 Bolus rate is fixed now so no range check is needed. Keep check for home though. Reply by hnguyen on 31 January 2022, 14:03 > Removed bolus range check. Reply by Sean Nash on 01 February 2022, 13:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:24 https://devapps.diality.us/cru/HD-DEN-11250-1#c11790 I don't think this will work. When you stop pump above, you will leave this state, so you will never get into the if condition below. I think the 1 second delay and check for occlusion should be handled in the SelfTests.c. Reply by hnguyen on 31 January 2022, 14:09 > Reversed the code to the original. > Now, implemented check for occlusion in SelfTests.c Reply by Sean Nash on 01 February 2022, 13:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:28 https://devapps.diality.us/cru/HD-DEN-11250-1#c11791 Not sure if check for prime empty makes sense. An insufficient Heparin alarm should always occur first, so empty check would be unreachable. Reply by hnguyen on 31 January 2022, 14:10 > Removed checkForPrimeEmpty(). Reply by Sean Nash on 01 February 2022, 13:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 09:44 https://devapps.diality.us/cru/HD-DEN-11250-1#c11789 Why is this commented out? If alarm, need to leave this state (and go to off state). Reply by hnguyen on 31 January 2022, 14:11 > Reversed the code to the original. > Uncommented result = SYRINGE_PUMP_OFF_STATE; Reply by Sean Nash on 01 February 2022, 13:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 February 2022, 10:28 https://devapps.diality.us/cru/HD-DEN-11250-1#c11886 Can we move this function up above with the other get functions? And update the other get functions to use the common get override value function like this one does. Reply by hnguyen on 15 February 2022, 13:57 > Updated other get functions to use common get override > function. > Added getS32, getU32, and getU08 override functions. Reply by Sean Nash on 15 February 2022, 15:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 February 2022, 10:34 https://devapps.diality.us/cru/HD-DEN-11250-1#c11889 Do not change data - should always be 40.0 as initialized. Reply by hnguyen on 15 February 2022, 11:46 > Removed line heparinBolusTargetRate.data = > heparinBolusTargetRate.ovInitData; Reply by Sean Nash on 15 February 2022, 15:03 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 February 2022, 10:34 https://devapps.diality.us/cru/HD-DEN-11250-1#c11888 Set ovData to ovInitData before zeroing it. Reply by hnguyen on 15 February 2022, 14:26 > Done. Reply by Sean Nash on 15 February 2022, 15:03 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 February 2022, 10:35 https://devapps.diality.us/cru/HD-DEN-11250-1#c11890 Remove extra blank lines. Reply by hnguyen on 15 February 2022, 11:38 > Done. Reply by Sean Nash on 15 February 2022, 15:03 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by Sean Nash on 31 January 2022, 10:50 https://devapps.diality.us/cru/HD-DEN-11250-1#c11799 I think we need some re-start code like this for bolus in SelfTests.c for when a recoverable alarm occurs during wet self-tests (stops pump) and user chooses to resume (pump should restart if bolus not finished). Reply by hnguyen on 31 January 2022, 17:07 > Moved startHeparinBolus() in transitionToWetSelfTests() to > handleWetSelfTestStartState(). Reply by Sean Nash on 01 February 2022, 13:18 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by Sean Nash on 31 January 2022, 10:47 https://devapps.diality.us/cru/HD-DEN-11250-1#c11798 I think DEN-11750 branch has a better version of this code. Reconcile this code with DEN-11750. Reply by hnguyen on 01 February 2022, 13:53 > Updated handlePOSTStateStart( ) function with the > handlePOSTStateStart( ) used in DEN-11750. Reply by Sean Nash on 15 February 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by Sean Nash on 31 January 2022, 10:34 https://devapps.diality.us/cru/HD-DEN-11250-1#c11796 Add a blank line between declarations and code. Reply by hnguyen on 01 February 2022, 14:20 > Line 489 F32 bolusVol = getTreatmentParameterF32() was moved. > it is no longer here. Reply by Sean Nash on 15 February 2022, 15:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:36 https://devapps.diality.us/cru/HD-DEN-11250-1#c11797 Why do we need the second part of this condition? When we start wet self tests, bolus volume delivered should be zero. Reply by hnguyen on 31 January 2022, 13:37 > Done. Removed the 2nd part ( && ( > getSyringePumpVolumeDelivered() < bolusVol ) Reply by Sean Nash on 01 February 2022, 13:21 > RESOLVED in CODE WALKTHROUGH. Reply by hnguyen on 01 February 2022, 13:36 > We don't need this here. startHeparinBolus() was moved to > handleWetSeltTestStartState(void) function. > > F32 bolusVol = getTreatmentParameterF32( > TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME ); > > setDialInPumpTargetFlowRate( > DIP_FLOW_RATE_SETUP_ML_MIN, MOTOR_DIR_FORWARD, > PUMP_CONTROL_MODE_OPEN_LOOP ); > fmdIntegratedVolume = 0.0; > > if ( ( bolusVol > 0.0 ) && ( > getSyringePumpVolumeDelivered() < bolusVol ) ) > { > startHeparinBolus(); // moved here > from startHeparinPump() in Dialysis.c > } Revision Comment by Sean Nash on 01 February 2022, 11:30 https://devapps.diality.us/cru/HD-DEN-11250-1#c11816 Not sure why we need stopPump flag - can't we just call the check function w/ no parameters? Reply by hnguyen on 01 February 2022, 13:50 > Done. Called checkForPrimeOcclusion(); with no parameters. Reply by Sean Nash on 15 February 2022, 15:06 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_selftest.c Revision Comment by Sean Nash on 31 January 2022, 10:33 https://devapps.diality.us/cru/HD-DEN-11250-1#c11795 Move these includes into user code block above. Cannot make changes outside user code blocks. Reply by hnguyen on 31 January 2022, 13:26 > Done. Reply by Sean Nash on 01 February 2022, 13:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:33 https://devapps.diality.us/cru/HD-DEN-11250-1#c11794 Remove blank line. Cannot make changes outside of user code blocks. Reply by hnguyen on 31 January 2022, 13:26 > Done. Reply by Sean Nash on 01 February 2022, 13:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:32 https://devapps.diality.us/cru/HD-DEN-11250-1#c11793 Remove this blank line. Cannot make changes outside user code blocks. Reply by hnguyen on 31 January 2022, 13:28 > Done. Reply by Sean Nash on 01 February 2022, 13:22 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_startup.c Revision Comment by Sean Nash on 15 February 2022, 10:50 https://devapps.diality.us/cru/HD-DEN-11250-1#c11893 Remove this line. This change was done in DEN-11750 branch. Reply by hnguyen on 15 February 2022, 11:34 > Removed the line #include "reg_crc.h" Reply by Sean Nash on 15 February 2022, 15:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 31 January 2022, 10:31 https://devapps.diality.us/cru/HD-DEN-11250-1#c11792 Need to uncomment this now that testing is done. Reply by hnguyen on 31 January 2022, 13:31 > Done. Reply by Sean Nash on 01 February 2022, 13:23 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by Sean Nash on 16 February 2022, 09:39 https://devapps.diality.us/cru/HD-DEN-11250-1#c11926 Why deleted? Reply by hnguyen on 16 February 2022, 10:17 > Reinstalled the case statement back to where it was. > case > MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE: > > handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message > ); Reply by Sean Nash on 17 February 2022, 10:30 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/SyringePump.h Revision Comment by Sean Nash on 01 February 2022, 11:32 https://devapps.diality.us/cru/HD-DEN-11250-1#c11817 No parameter needed in this function. Reply by hnguyen on 01 February 2022, 13:40 > Changed function prototype from BOOL checkForPrimeOcclusion( > BOOL stopPump ) to BOOL checkForPrimeOcclusion( void ); Reply by Sean Nash on 15 February 2022, 15:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: Common.h Revision Comment by Sean Nash on 15 February 2022, 10:45 https://devapps.diality.us/cru/HD-DEN-11250-1#c11892 Why are these here in Common.h? Move to sys_selftest.c in user defined section. Reply by Dara Navaei on 18 October 2023, 21:39 > RESOLVED in CODE WALKTHROUGH --- ID: HD-DEN-11250-1 https://devapps.diality.us/cru/HD-DEN-11250-1 Title: HD-DEN-11250_HD Syringe Pump Updates Statement of Objectives: State: Closed Summary: Author: hnguyen Moderator: hnguyen Reviewers: (2 active, 1 completed*) Dara Navaei (*) Sean Nash Behrouz NematiPour