This is a list of all comments for HD-DEN-11928-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Sean Nash on 22 March 2022, 13:18 
https://devapps.diality.us/cru/HD-DEN-11928-2#c12589

  Just delete this line of code.

  Reply by hnguyen on 22 March 2022, 13:27
  > Removed line             //noNewTreatment = ( TRUE ==
  > ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment
  > );

    Reply by Sean Nash on 22 March 2022, 16:27
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 22 March 2022, 13:17 
https://devapps.diality.us/cru/HD-DEN-11928-2#c12588

  Just delete this line of code.

  Reply by hnguyen on 22 March 2022, 13:28
  > Removed line //    payload.alarmsFlags |= (
  > almStatus.noNewTreatment               ?
  > BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT)   : 0
  > );

    Reply by Sean Nash on 22 March 2022, 16:27
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 22 March 2022, 13:17 
https://devapps.diality.us/cru/HD-DEN-11928-2#c12587

  Just delete this code.

  Reply by hnguyen on 22 March 2022, 13:29
  > Removed
  > //    if ( TRUE == getNoNewTreatmentStatus() )
  > //    {
  > //        rejReason =
  > REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED;
  > //    }

    Reply by Sean Nash on 22 March 2022, 16:27
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-11928-2 https://devapps.diality.us/cru/HD-DEN-11928-2

Title: HD-DEN-11928_DG Conductivity Update
Statement of Objectives:


State: Closed

Summary: 

Author: hnguyen
Moderator: hnguyen
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Michael Garthwaite