This is a list of all comments for HD-DEN-12441-3.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/TreatmentStop.c
Revision Comment by Sean Nash on 11 May 2022, 09:29 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12796

  I think syringe pump is stopped in every scenario so maybe this
  should stay here instead of in various setup functions.

  Reply by Darren Cox on 11 May 2022, 15:16
  > Done

    Reply by Sean Nash on 13 May 2022, 16:08
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 May 2022, 09:27 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12795

  I think VDi and VDo valves are closed in every scenario so
  maybe they should just be set here instead of in the various
  setup functions.

  Reply by Darren Cox on 11 May 2022, 15:16
  > Done

    Reply by Sean Nash on 13 May 2022, 16:08
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 May 2022, 09:32 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12797

  Consider reading these blocked flags into local booleans so you
  don't have to keep calling these functions (and avoid
  possibility that function returns different value in subsequent
  call).

  Reply by Darren Cox on 11 May 2022, 15:17
  > Done

    Reply by Sean Nash on 13 May 2022, 16:08
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 May 2022, 09:41 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12799

  Is this timer reset to 0 when we go to states where blood is
  recirculating?  I think it should be.

  Reply by Darren Cox on 11 May 2022, 14:49
  > Yes.  setupForBloodRecirculationState() does this on Init and
  > entry to Blood Recirculation.

    Reply by Sean Nash on 13 May 2022, 16:08
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 May 2022, 09:39 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12798

  Put spaces between parenthesis and inner condition code.
  Prefer literals be on right side of compare operators except
  for "==".

  Reply by Darren Cox on 11 May 2022, 15:16
  > Done

    Reply by Sean Nash on 13 May 2022, 16:08
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Sean Nash on 11 May 2022, 09:05 
https://devapps.diality.us/cru/HD-DEN-12441-3#c12792

  What is the purpose of this new code?  Should have a comment
  above to make clear.  
  Need to address TODOs.

  Reply by Darren Cox on 11 May 2022, 14:31
  > This was a place holder for NVRAM saving of Treatment Time.
  > I removed it.

    Reply by Sean Nash on 13 May 2022, 16:09
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-12441-3 https://devapps.diality.us/cru/HD-DEN-12441-3

Title: HD-DEN-12441_SW Dev Sprint 67 Darren
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Michael Garthwaite